Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing e2e test cases for flag --plain-http #633

Closed
yizha1 opened this issue Apr 17, 2023 · 3 comments · Fixed by #679
Closed

Missing e2e test cases for flag --plain-http #633

yizha1 opened this issue Apr 17, 2023 · 3 comments · Fixed by #679
Assignees
@JeyJeyGao
Labels
testing
Milestone
v1.0.0-rc.6

Comments

@yizha1
Copy link
Contributor

yizha1 commented Apr 17, 2023

What is the areas you experience the issue in?

Notation CLI

What is not working as expected?

Missing e2e test cases for flag --plain-http, which exists for the following commands. This flag allows users to establish insecure connections to registries, so it should be tested properly.

  • notation sign
  • notation verify
  • notation list
  • notation inspect
  • notation login

What did you expect to happen?

Add e2e test cases for flag --plain-http used by all notation CLI commands

How can we reproduce it?

N/A

Describe your environment

N/A

What is the version of your Notation CLI or Notation Library?

Notation CLI v1.0.0-rc.3
@yizha1 yizha1 added bug Something isn't working triage Need to triage labels Apr 17, 2023
@yizha1 yizha1 added testing and removed bug Something isn't working labels Apr 20, 2023
@patrickzheng200 patrickzheng200 self-assigned this Apr 25, 2023
@patrickzheng200 patrickzheng200 added this to the 1.0.0 milestone Apr 25, 2023
@patrickzheng200
Copy link
Contributor

I will take this one.

@yizha1 yizha1 removed the triage Need to triage label Apr 26, 2023
@toddysm
Copy link
Contributor

toddysm commented May 2, 2023

@patrickzheng200 please link the spec for --insecure to this issue.

@yizha1 yizha1 assigned JeyJeyGao and unassigned patrickzheng200 May 18, 2023
@JeyJeyGao JeyJeyGao mentioned this issue May 23, 2023
Merged
@yizha1 yizha1 moved this from Todo to PR Review in Notary Project Planning Board May 23, 2023
@yizha1
Copy link
Contributor Author

yizha1 commented May 23, 2023 •
edited
Loading

update milestone to v1.0.0-rc.6 per discussion in community call on 5/22/2023

@yizha1 yizha1 modified the milestones: 1.0.0, v1.0.0-rc.6 May 23, 2023
shizhMSFT pushed a commit that referenced this issue May 25, 2023
@JeyJeyGao
test: add e2e test cases for flag --insecure-registry (#679)
98f5290 
Feature:
- add E2E testing TLS support for Github Action environment

Test:
- added `--insecure-registry` test for sign, verify, inspect, list

> **Note** `login` command E2E test cases are not included in the PR
because it needs to setup credential store in Github Action and should
be done in another PR. Added an issue to track it #680

Resolves #633 
Signed-off-by: Junjie Gao <[email protected]>

---------

Signed-off-by: Junjie Gao <[email protected]>
@github-project-automation github-project-automation bot moved this from PR Review to Done in Notary Project Planning Board May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JeyJeyGao JeyJeyGao

Labels
testing
Projects
Notary Project Planning Board
Status: Done
Milestone
v1.0.0-rc.6
Development

Successfully merging a pull request may close this issue.

test: add e2e test cases for flag --insecure-registry JeyJeyGao/notation
4 participants
@toddysm @JeyJeyGao @patrickzheng200 @yizha1