Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: blob verify command #1137

Merged
merged 59 commits into from
Feb 14, 2025
Merged

feat: blob verify command #1137

merged 59 commits into from
Feb 14, 2025

Conversation

Two-Hearts
Copy link
Contributor

@Two-Hearts Two-Hearts commented Jan 7, 2025 •
edited
Loading

This PR adds blob verify command with E2E tests.

@Two-Hearts
blob signing
1619d18 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
blob signing
5870423 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
update
c6da7dc 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
Merge branch 'notaryproject:main' into blobsign
c13744e
@Two-Hearts
add tests
97c3fcd 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
fix test
f0db92f 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
fix test
9cf65b8 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
fix e2e test
e8fe8c6 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
add e2e tests
cb997c7 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
add e2e tests
07d0ffb 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
fix e2e tests
cf40ba2 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
fix e2e test
1051ad4 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
add more e2e tests
cf5fecb 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
add more e2e tests
fc4dcfc 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
fix e2e test
576a286 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
add more tests
0c984a0 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
Merge branch 'notaryproject:main' into blobsign
8474d58
@Two-Hearts
update
14a1f3e 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
fix e2e test
752afe6 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
resolve conflicts
c30e199 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
update
bc8f710 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
initial commit
9ce5ac9 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
update
9e84a3f 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
fix tests
2659ff7 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts Two-Hearts requested a review from shizhMSFT February 12, 2025 03:22
JeyJeyGao
JeyJeyGao reviewed Feb 12, 2025
View reviewed changes
@Two-Hearts
update
3e223d0 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
fix e2e tests
e425c4d 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
update
ea95204 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
update
b9a0b46 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts Two-Hearts requested a review from JeyJeyGao February 12, 2025 08:42
JeyJeyGao
JeyJeyGao previously approved these changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a nit suggestion.

@Two-Hearts
update
ace6b69 
Signed-off-by: Patrick Zheng <[email protected]>
JeyJeyGao
JeyJeyGao previously approved these changes Feb 13, 2025
View reviewed changes
shizhMSFT
shizhMSFT reviewed Feb 13, 2025
View reviewed changes
@shizhMSFT shizhMSFT mentioned this pull request Feb 13, 2025
Merged
@Two-Hearts
update
cffbf3d 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
update
0e906a4 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
update
35d5e0c 
Signed-off-by: Patrick Zheng <[email protected]>
JeyJeyGao
JeyJeyGao previously approved these changes Feb 14, 2025
View reviewed changes
Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shizhMSFT
shizhMSFT reviewed Feb 14, 2025
View reviewed changes
@Two-Hearts
update
4c3571c 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts Two-Hearts requested a review from shizhMSFT February 14, 2025 02:50
@Two-Hearts Two-Hearts mentioned this pull request Feb 14, 2025
Open
shizhMSFT
shizhMSFT approved these changes Feb 14, 2025
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

JeyJeyGao
JeyJeyGao approved these changes Feb 14, 2025
View reviewed changes
Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Two-Hearts Two-Hearts merged commit 4808e08 into notaryproject:main Feb 14, 2025
7 checks passed
@Two-Hearts Two-Hearts deleted the blobverify branch February 14, 2025 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FeynmanZhou FeynmanZhou FeynmanZhou left review comments

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@JeyJeyGao JeyJeyGao JeyJeyGao approved these changes

@gokarnm gokarnm Awaiting requested review from gokarnm gokarnm is a code owner

@NiazFK NiazFK Awaiting requested review from NiazFK NiazFK is a code owner

@priteshbandi priteshbandi Awaiting requested review from priteshbandi priteshbandi is a code owner

@rgnote rgnote Awaiting requested review from rgnote rgnote is a code owner

@toddysm toddysm Awaiting requested review from toddysm toddysm is a code owner

@vaninrao10 vaninrao10 Awaiting requested review from vaninrao10 vaninrao10 is a code owner

@yizha1 yizha1 Awaiting requested review from yizha1 yizha1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Two-Hearts @shizhMSFT @FeynmanZhou @JeyJeyGao