Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update policy command to support OCI trust policy #1173

Merged
merged 27 commits into from
Feb 21, 2025
Merged

feat: update policy command to support OCI trust policy #1173

merged 27 commits into from
Feb 21, 2025

Conversation

JeyJeyGao
Copy link
Contributor

@JeyJeyGao JeyJeyGao commented Feb 14, 2025 •
edited
Loading

Feat:

  • added OCI trust policy support for notation policy command
  • print out the imported trust policy file path

Fix:

  • command spec docs

Test:

  • improved E2E

Resolves #1138

@codecov Codecov
Copy link

codecov bot commented Feb 14, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 93.10345% with 4 lines in your changes missing coverage. Please review.

Project coverage is 76.29%. Comparing base (76936ad) to head (7c44687).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
cmd/notation/policy/import.go 88.88% 3 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1173      +/-   ##
==========================================
+ Coverage   75.99%   76.29%   +0.29%     
==========================================
  Files          69       69              
  Lines        3603     3623      +20     
==========================================
+ Hits         2738     2764      +26     
+ Misses        669      665       -4     
+ Partials      196      194       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JeyJeyGao JeyJeyGao marked this pull request as ready for review February 17, 2025 03:13
shizhMSFT
shizhMSFT previously approved these changes Feb 17, 2025
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Two-Hearts
Two-Hearts reviewed Feb 18, 2025
View reviewed changes
@JeyJeyGao
fix: resolve comments
d780b27 
Signed-off-by: Junjie Gao <[email protected]>
@JeyJeyGao
fix: update
0bec3a7 
Signed-off-by: Junjie Gao <[email protected]>
@JeyJeyGao
fix: update
ea441f3 
Signed-off-by: Junjie Gao <[email protected]>
@JeyJeyGao
fix: add imported trust policy file path
db619c5 
Signed-off-by: Junjie Gao <[email protected]>
@JeyJeyGao
fix: update
ae02b6f 
Signed-off-by: Junjie Gao <[email protected]>
@JeyJeyGao
fix: update
5780c63 
Signed-off-by: Junjie Gao <[email protected]>
Two-Hearts
Two-Hearts reviewed Feb 19, 2025
View reviewed changes
@JeyJeyGao
fix: update
401149f 
Signed-off-by: Junjie Gao <[email protected]>
@JeyJeyGao
fix: update
4228f75 
Signed-off-by: Junjie Gao <[email protected]>
Two-Hearts
Two-Hearts reviewed Feb 19, 2025
View reviewed changes
Two-Hearts
Two-Hearts previously approved these changes Feb 19, 2025
View reviewed changes
Copy link
Contributor

@Two-Hearts Two-Hearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JeyJeyGao
fix: update
8c56a5e 
Signed-off-by: Junjie Gao <[email protected]>
@JeyJeyGao
fix: E2E
a6d5846 
Signed-off-by: Junjie Gao <[email protected]>
Two-Hearts
Two-Hearts reviewed Feb 20, 2025
View reviewed changes
@JeyJeyGao
fix: update
98f8de0 
Signed-off-by: Junjie Gao <[email protected]>
@JeyJeyGao
fix: update
2af84d6 
Signed-off-by: Junjie Gao <[email protected]>
@JeyJeyGao
fix: update
54d153b 
Signed-off-by: Junjie Gao <[email protected]>
@JeyJeyGao
fix: update
683101e 
Signed-off-by: Junjie Gao <[email protected]>
Two-Hearts
Two-Hearts previously approved these changes Feb 20, 2025
View reviewed changes
Copy link
Contributor

@Two-Hearts Two-Hearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shizhMSFT
shizhMSFT previously approved these changes Feb 20, 2025
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with suggestions

@JeyJeyGao
fix: format the table
46bab16 
Signed-off-by: Junjie Gao <[email protected]>
@JeyJeyGao JeyJeyGao dismissed stale reviews from shizhMSFT and Two-Hearts via 46bab16 February 21, 2025 01:49
Two-Hearts
Two-Hearts approved these changes Feb 21, 2025
View reviewed changes
Copy link
Contributor

@Two-Hearts Two-Hearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shizhMSFT
shizhMSFT approved these changes Feb 21, 2025
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JeyJeyGao JeyJeyGao merged commit 5dd2ccf into notaryproject:main Feb 21, 2025
7 checks passed
@JeyJeyGao JeyJeyGao deleted the fix/oci_plicy branch February 21, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@Two-Hearts Two-Hearts Two-Hearts approved these changes

@gokarnm gokarnm Awaiting requested review from gokarnm gokarnm is a code owner

@NiazFK NiazFK Awaiting requested review from NiazFK NiazFK is a code owner

@priteshbandi priteshbandi Awaiting requested review from priteshbandi priteshbandi is a code owner

@rgnote rgnote Awaiting requested review from rgnote rgnote is a code owner

@toddysm toddysm Awaiting requested review from toddysm toddysm is a code owner

@vaninrao10 vaninrao10 Awaiting requested review from vaninrao10 vaninrao10 is a code owner

@yizha1 yizha1 Awaiting requested review from yizha1 yizha1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OCI policy command update
3 participants
@JeyJeyGao @shizhMSFT @Two-Hearts