Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notation sign CLI spec #341

Merged
merged 23 commits into from
Oct 4, 2022
Merged

Add notation sign CLI spec #341

merged 23 commits into from
Oct 4, 2022

Conversation

yizha1
Copy link
Contributor

@yizha1 yizha1 commented Sep 20, 2022

This PR is to create a new CLI spec for notation sign under a new directory named commandline. The notation-cli.md will be updated later to provide a list of notation commands and link each command to individual spec.

@yizha1 yizha1 self-assigned this Sep 20, 2022
@yizha1 yizha1 added cli Issue or PR released to Notation CLI spec Specifications to define the product requirements labels Sep 20, 2022
@yizha1 yizha1 added this to the RC-1 milestone Sep 20, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2022

Codecov Report

Merging #341 (2c4e454) into main (8bec8a7) will decrease coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #341      +/-   ##
==========================================
- Coverage   30.62%   30.54%   -0.08%     
==========================================
  Files          25       25              
  Lines        1610     1614       +4     
==========================================
  Hits          493      493              
- Misses       1104     1108       +4     
  Partials       13       13              
Impacted Files Coverage Δ
cmd/notation/verify.go 18.62% <0.00%> (-0.38%) ⬇️
internal/cmd/signer.go 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@yizha1 yizha1 requested a review from gokarnm September 23, 2022 05:21
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

cc. @gokarnm for review

Copy link
Contributor

@gokarnm gokarnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Except for expiry duration which I think we should switch to an expiry date time instead.

@yizha1 yizha1 requested a review from shizhMSFT September 30, 2022 12:14
@yizha1 yizha1 requested a review from shizhMSFT September 30, 2022 14:48
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with suggestions

@dtzar dtzar merged commit f66ab6c into notaryproject:main Oct 4, 2022
@yizha1 yizha1 linked an issue Oct 8, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Issue or PR released to Notation CLI spec Specifications to define the product requirements
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Define experience for notation sign command
7 participants