major: Ios native port #791

Slesarew · 2021-08-04T13:33:44Z

This is a major re-write of the app.

Pure Rust backend

All logic was moved to Rust native code; this includes key storage, transaction parsing, signing, history, etc.
sled is used as database engine
metadata and networc specifications could be imported with fountain QR videos
support message signing and legacy multiframe transactions
cryptography imported directly from Substrate code

iOS frontend

iOS frontend written with modern SwiftUI framework
QR scanner is multithreaded and thus works at rates of at least 30fps
Seed phrases are stored with SecureEnclave
General UI/UX changes to improve usability and simplify things

Ethereum

is not supported anymore; to return support - either fork old RN branch or implement everything in pure Rust

Legacy code

Almost nothing remains from version 4.5*

Most of Rust code is inherited from https://github.com/paritytech/parity-signer/tree/payload-parser-rust

This PR would address the following issues:

#407
#318
#408
#758
#457
#713
#724
#736
#739
#767

feat: metadata versions added to constants

removed som non-essential networks due to metadata loading issues

…ponent fixed

…ching block

* feat: MWP fast Rust-processed QR scanner frontend * build: temporarily switch dependency rust-native to side branch * feat: implement rust code for fountain parsing. Saving point for partial dependencies upgrade attempts * feat: add metadata through fountain QR codes! (go to network settings>"network name">ManageMetadata>Fast Qr Scanner) * fix: lint and types * fix: typo in constants * fix: multiple minor bugs * refactor: return rust native libs where they belong (#751) * ref: return rust native libs where they belong * docs: lost gitignore * refactor: move reference animated qr code generator to external repository * build: move header files in ios build part * build: add more memory for ios node build * build: add more memory for ios node build in a different way * build: revert ios build changes, modify bitrise script to allocate less memory * build: duplicate headers for ios * fix: Transaction parser (#754) * feat: parse generic transaction. Ugly but now works. * test: increase e2e timeout * fix: lint * feat: automatically generate built-in metadata (#755) * feat: add rust code to automatically fetch and generate built-in metadata constants * test: add extra paths for linter to ignore * feat: automatically update constants/networkSpecs.ts with new metadata info * fix: add blake2 hash to metadata handles; use it as ID if no spec_name or spec_version is available * fix: blake2 hash in networkSpecs constants * fix: add hashes for centrifuge and edgeware * fix: metadata autogeneration lint * build: update failure_derive to 1.8.0 * build: convenience reminder in build script * fix: multiple fixes to allow versionless metadata * test: fix unit tests to recognize versioned metadata

* perf: moved metadata handle generator to rust * refactor: lint and types * build: try ti disable flipper * fix: update metadata * test: increase alert timeout * test: typo in consts * fix: merged last commit that was dropped from last squash for some reason

* build: bump polkadot/api version to latest * fix: red boxes on registering networks * build: mess with upgrades and lint * feat: can delete unused metadata (except for built-in probably)

* upgrade polkadot and react-native * test: disabled failing tests temporarily * test: restore tests * fix: lint * test: fix ts-ignore updated rule * fix: lint and types * test: bump nodejs version * test: bump wasm-crypto needed for tests * fix: update metadata

kirushik · 2021-08-30T11:12:21Z

I'm OK with the general direciton of this — but am not currenlty available for a thorough code review of a +33,174 −32,944 pull request in a language I'm not too fluent with.
This only leaves me with an opportunity to do a sprt of QA/acceptance testing of the app itself — and this PR has no info on how I can get a pre-release version built from this branch for testing.

Slesarew · 2021-08-30T12:58:42Z

how I can get a pre-release version built from this branch for testing.

That's what I meant really, I don't thing plowing through all this code is feasible now.

To build, first run
./scripts/build.sh ios
Then just build the workspace from ios directory in Xcode. It's already in the readme, but I'll need to improve that documentation further once this goes into more stable state.

s3krit · 2021-09-03T13:14:03Z

As an update to this; there is now a build available in TestFlight. Given an Apple ID, I can add whomever for QA/testing.

TriplEight · 2021-09-10T18:25:43Z

Please don't do such huge PRs, it's unreal to review it.
Now, unfortunately, I do not have the iOS device for testing, but think it's worth getting one.

vas3k

Same as for #793: tested the last build from TestFlight: seed creation, metadata update, exporting, transaction parsing, transaction signing, extension integration

UI looks way better than in Android version but still need improvements

blockchainunchained · 2021-09-22T11:12:24Z

You awesome beast @Slesarew can I please buy you a beer?

nuke-web3 · 2021-09-22T15:43:39Z

Congratulations on this @Slesarew 🍻

kianenigma · 2021-09-22T17:26:39Z

Congratulations! 🥂

mcdonagg · 2021-09-23T00:45:18Z

This is awesome, thank you for your hard work on this, how do I get my hands on it?

Slesarew · 2021-09-23T06:29:47Z

This is awesome, thank you for your hard work on this, how do I get my hands on it?

There won't be ant app store releases until we are done with testing (and hopefully audits!), but it is really trivial to build (at your own risk, as usual, the frontend does not even have any tests as it is not in final state), you need rust and xcode or android studio depending on target. So, first it is ./scripts/build.sh iosor ./scripts/build.sh android and then open corresponding IDE and build. Android studio might need to be properly upgraded though and you'll need NDK obviously. And there is effectively no light color mode in android at the moment, as the Signer was always black, I've started with it - so switch to dark mode in the phone first.

Slesarew and others added 30 commits March 10, 2021 13:36

fix: update metadata

da5d68b

docs: created issue for stock metadata updates

ecd983d

docs: lint

f1bd13f

feat: add generalized metadata storage mwp

6aefe61

feat: metadata info on network details page (early stub)

761561d

feat: invalid metadata message

34acbe5

feat: built-in metadata loaded in constants

a2d4b6d

feat: metadata versions added to constants

Merge branch 'master' into metadata-management

0330817

Merge branch 'master' into metadata-management

3a373d7

fix!: metadata is actuallty loaded;

1d069b2

removed som non-essential networks due to metadata loading issues

fix: annoying hooks warning about updating component from another com…

be21e51

…ponent fixed

fix: smoother metadata loading; initiation moved to separate from fet…

9754f1d

…ching block

ref: merged networkscontext and registriescontext

78a12e4

fix: remove process race on init and small fixes

b5cc792

fix: infinite useEffect cycle in payload card; probably there is more

87c0b8a

feat: show list of available metadata packages for given network

78c99d8

feat: choose metadata from network settings submenu

5e90750

test: fix typos in unit tests

41eae4e

test: fix tests and some lint/type errors

b20c3bd

feat: Metadata management page (#760)

4cb7d39

* build: bump polkadot/api version to latest * fix: red boxes on registering networks * build: mess with upgrades and lint * feat: can delete unused metadata (except for built-in probably)

build: bump node version for e2e

8619f6b

build: bump node version in bitrise.yml

cbe8a74

test: teach signing test to scroll down

97002d6

test: fix addNewNetwork signing test with scrolling

7aa668a

test: forgot to import scrolling tap everywhere it's needed

d1770ab

fix: update westend metadata

59dc5d5

build: build rust for detox

472728d

docs: reference to uos

962e855

Slesarew requested review from vas3k, s3krit and kirushik August 27, 2021 17:50

Slesarew linked an issue Sep 1, 2021 that may be closed by this pull request

Can't sign messages generated by the latest master build of the extension #779

Closed

Slesarew mentioned this pull request Sep 1, 2021

Can't sign messages generated by the latest master build of the extension #779

Closed

Slesarew linked an issue Sep 4, 2021 that may be closed by this pull request

Unable to parse QR data while signing the transaction through parity signer app #809

Closed

Slesarew requested a review from TriplEight September 7, 2021 08:31

fix: signing db checksum mismatch bugfix

86b5fcf

docs: mark how releases are tagged

587bdbe

Slesarew mentioned this pull request Sep 17, 2021

No implementation found for SubstrateSignModule.ethkeyBrainwalletAddress #713

Closed

vas3k approved these changes Sep 22, 2021

View reviewed changes

Slesarew merged commit b9fa369 into master Sep 22, 2021

Slesarew deleted the ios-native-port branch September 22, 2021 11:11

burdges mentioned this pull request Sep 22, 2021

Erasure coding maciejhirsz/uos#7

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

major: Ios native port #791

major: Ios native port #791

Slesarew commented Aug 4, 2021 •

edited

Loading

kirushik commented Aug 30, 2021

Slesarew commented Aug 30, 2021

s3krit commented Sep 3, 2021

TriplEight commented Sep 10, 2021

vas3k left a comment

blockchainunchained commented Sep 22, 2021 •

edited

Loading

nuke-web3 commented Sep 22, 2021

kianenigma commented Sep 22, 2021

mcdonagg commented Sep 23, 2021

Slesarew commented Sep 23, 2021

major: Ios native port #791

major: Ios native port #791

Conversation

Slesarew commented Aug 4, 2021 • edited Loading

Pure Rust backend

iOS frontend

Ethereum

Legacy code

This PR would address the following issues:

kirushik commented Aug 30, 2021

Slesarew commented Aug 30, 2021

s3krit commented Sep 3, 2021

TriplEight commented Sep 10, 2021

vas3k left a comment

Choose a reason for hiding this comment

blockchainunchained commented Sep 22, 2021 • edited Loading

nuke-web3 commented Sep 22, 2021

kianenigma commented Sep 22, 2021

mcdonagg commented Sep 23, 2021

Slesarew commented Sep 23, 2021

Slesarew commented Aug 4, 2021 •

edited

Loading

blockchainunchained commented Sep 22, 2021 •

edited

Loading