Solution option to solve #1326 problem #1327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm... This change will assume it is ISO 8859-1 if the decoding fails. This is correct in some cases, but not all. So I'm not sure this is the correct place to put that code. |
samhed
requested changes
Dec 5, 2019
There was a problem hiding this comment.
Just like @CendioOssman said, we don't always want to make this assumption. Currently, however, there are only two places where we use decodeUTF8(), both for desktopName. Could you place your try-catches in _negotiate_server_init() and _handleDesktopName() in core/rfb.js instead?
samhed
approved these changes
Dec 7, 2019
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add try catch to
decodeUTF8function to solve #1326