Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code literal generation for NodaTime Period #1294

Closed
roji opened this issue Mar 4, 2020 · 0 comments · Fixed by #1558
Closed

Code literal generation for NodaTime Period #1294

roji opened this issue Mar 4, 2020 · 0 comments · Fixed by #1558
Assignees
@roji
Labels
enhancement New feature or request
Milestone
5.0.0

Comments

@roji
Copy link
Member

roji commented Mar 4, 2020 •
edited
Loading

Split off from #854, because Period requires the addition operator which is only supported upstream in EF Core 5.0 via dotnet/efcore#20142.

Work done in https://github.com/roji/efcore.pg/tree/NodaTimeZonedDateTimeCodeLiteral, to be merged after the next EF Core sync.
@roji roji added the enhancement New feature or request label Mar 4, 2020
@roji roji added this to the 5.0.0 milestone Mar 4, 2020
@roji roji self-assigned this Mar 4, 2020
@roji roji changed the title Code literal generation for NodaTime ZonedDateTime Code literal generation for NodaTime Period Mar 4, 2020
roji added a commit to roji/efcore.pg that referenced this issue Mar 4, 2020
@roji
Code literal support for NodaTime Period
4f83496 
Closes npgsql#1294
roji added a commit to roji/efcore.pg that referenced this issue Nov 4, 2020
@roji
Code literal generation for NodaTime Period
a180249 
Closes npgsql#1294
@roji roji mentioned this issue Nov 4, 2020
Merged
roji added a commit to roji/efcore.pg that referenced this issue Nov 4, 2020
@roji
Code literal generation for NodaTime Period
e9f7af2 
Closes npgsql#1294
@roji roji closed this as completed in #1558 Nov 9, 2020
roji added a commit that referenced this issue Nov 9, 2020
@roji
Code literal generation for NodaTime Period (#1558)
509187f 
Closes #1294
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roji roji

Labels
enhancement New feature or request
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Code literal generation for NodaTime Period roji/efcore.pg
1 participant
@roji