Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up plugin evaluatable definitions #1397

Closed
roji opened this issue May 29, 2020 · 0 comments · Fixed by #1398
Closed

Clean up plugin evaluatable definitions #1397

roji opened this issue May 29, 2020 · 0 comments · Fixed by #1398
Assignees
@roji
Labels
cleanup nodatime
Milestone
5.0.0

Comments

@roji
Copy link
Member

roji commented May 29, 2020

With dotnet/efcore#13454 merged upstream, we can now clean up our hacky, stringly-typed evaluatable support for plugins.
@roji roji added the refactor label May 29, 2020
@roji roji added this to the 5.0.0 milestone May 29, 2020
@roji roji self-assigned this May 29, 2020
@roji roji added cleanup and removed refactor labels May 29, 2020
@roji roji changed the title Clean up plugin evaluatable definitions Clean up NodaTime plugin evaluatable definitions May 29, 2020
@roji roji added the nodatime label May 29, 2020
roji added a commit to roji/efcore.pg that referenced this issue May 29, 2020
@roji
Move NodaTime evaluatable definitions out to the plugin
7ec04eb 
Closes npgsql#1397
@roji roji mentioned this issue May 29, 2020
Merged
@roji roji changed the title Clean up NodaTime plugin evaluatable definitions Clean up plugin evaluatable definitions May 29, 2020
roji added a commit that referenced this issue May 29, 2020
@roji
Move NodaTime evaluatable definitions out to the plugin
8257918 
Closes #1397
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roji roji

Labels
cleanup nodatime
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Move NodaTime evaluatable definitions out to the plugin roji/efcore.pg
1 participant
@roji