Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to the new EF Core plugin model #658

Closed
roji opened this issue Sep 30, 2018 · 0 comments · Fixed by #672
Closed

Switch to the new EF Core plugin model #658

roji opened this issue Sep 30, 2018 · 0 comments · Fixed by #672
Assignees
@roji
Labels
cleanup NetTopologySuite nodatime
Milestone
2.2.0

Comments

@roji
Copy link
Member

roji commented Sep 30, 2018 •
edited
Loading

For 2.1, we developed our own plugin model (#300) to support NodaTime, NetTopologySuite and others. Much of that work has been integrated into EF Core itself for 2.2, so we should drop our own model and reimplement the plugins in the new, standard way.

Note blocking lack of support for specifying evaluatable from plugins (dotnet/efcore#13454).
@roji roji added the refactor label Sep 30, 2018
@roji roji added this to the 2.2.0 milestone Sep 30, 2018
@roji roji self-assigned this Sep 30, 2018
@roji roji mentioned this issue Sep 30, 2018
Closed
This was referenced Oct 18, 2018
Closed
Closed
Closed
roji added a commit to roji/efcore.pg that referenced this issue Oct 21, 2018
@roji
Switch to new EF Core plugin model
2606034 
Notes:

* Added some missing NTS translations
* The new EF Core plugin model doesn't yet support specifying
  evaluatable (dotnet/efcore#13454),
  so we currently hack that up inside the main provider using type
  names as strings.

Fixes npgsql#658
@roji roji mentioned this issue Oct 21, 2018
Merged
roji added a commit to roji/efcore.pg that referenced this issue Oct 27, 2018
@roji
Switch to new EF Core plugin model
19d5cda 
Notes:

* Added some missing NTS translations
* The new EF Core plugin model doesn't yet support specifying
  evaluatable (dotnet/efcore#13454),
  so we currently hack that up inside the main provider using type
  names as strings.

Fixes npgsql#658
roji added a commit to roji/efcore.pg that referenced this issue Oct 29, 2018
@roji
Switch to new EF Core plugin model
84fb709 
Notes:

* Added some missing NTS translations
* The new EF Core plugin model doesn't yet support specifying
  evaluatable (dotnet/efcore#13454),
  so we currently hack that up inside the main provider using type
  names as strings.

Fixes npgsql#658
@roji roji closed this as completed in #672 Oct 29, 2018
roji added a commit that referenced this issue Oct 29, 2018
@roji
Switch to new EF Core plugin model
e7bea84 
Notes:

* Added some missing NTS translations
* The new EF Core plugin model doesn't yet support specifying
  evaluatable (dotnet/efcore#13454),
  so we currently hack that up inside the main provider using type
  names as strings.

Fixes #658
@roji roji mentioned this issue Nov 15, 2018
Closed
@roji roji added cleanup and removed refactor labels May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roji roji

Labels
cleanup NetTopologySuite nodatime
Projects
None yet
Milestone
2.2.0
Development

Successfully merging a pull request may close this issue.

Switch to new EF Core plugin model roji/efcore.pg
1 participant
@roji