Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix prereleases to have a number suffix #492

Merged
merged 2 commits into from
Nov 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/content/release-please-config-json.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"group-pull-request-title-pattern": "chore: release ${version}",
"pull-request-title-pattern": "chore: release${component} ${version}",
"changelog-sections": {{{ json changelogTypes }}},
"prerelease-type": "pre",
"prerelease-type": "pre.0",
"packages": {
"{{ pkgPath }}": {
{{#if isRoot}}
Expand Down
2 changes: 1 addition & 1 deletion release-please-config.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,5 +36,5 @@
},
"group-pull-request-title-pattern": "chore: release ${version}",
"pull-request-title-pattern": "chore: release${component} ${version}",
"prerelease-type": "pre"
"prerelease-type": "pre.0"
}
6 changes: 3 additions & 3 deletions tap-snapshots/test/apply/source-snapshots.js.test.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -1401,7 +1401,7 @@ release-please-config.json
"hidden": true
}
],
"prerelease-type": "pre",
"prerelease-type": "pre.0",
"packages": {
".": {
"package-name": ""
Expand Down Expand Up @@ -3081,7 +3081,7 @@ release-please-config.json
"hidden": true
}
],
"prerelease-type": "pre",
"prerelease-type": "pre.0",
"packages": {
".": {
"package-name": "",
Expand Down Expand Up @@ -4468,7 +4468,7 @@ release-please-config.json
"hidden": true
}
],
"prerelease-type": "pre",
"prerelease-type": "pre.0",
"packages": {
"workspaces/a": {},
"workspaces/b": {}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,11 @@ exports[`test/release/release-manager.js TAP npm/cli > must match snapshot 1`] =
gh workflow run update-cli.yml --repo npm/documentation
\`\`\`

- [ ] 7. Merge release PR
- [ ] 7. Approve and Merge release PR

\`\`\`sh
gh pr review --approve
\`\`\`

\`\`\`sh
gh pr merge --rebase
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,11 @@ exports[`test/release/release-manager.js TAP prerelease > must match snapshot 1`
gh workflow run update-cli.yml --repo npm/documentation
\`\`\`

- [ ] 6. Merge release PR
- [ ] 6. Approve and Merge release PR

\`\`\`sh
gh pr review --approve
\`\`\`

\`\`\`sh
gh pr merge --rebase
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,11 @@ exports[`test/release/release-manager.js TAP workspace names > expect resolving
gh workflow run update-cli.yml --repo npm/documentation
\`\`\`

- [ ] 7. Merge release PR
- [ ] 7. Approve and Merge release PR

\`\`\`sh
gh pr review --approve
\`\`\`

\`\`\`sh
gh pr merge --rebase
Expand Down