fix(js): set --ws=false when running npm config for jest e2e #29887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
View your CI Pipeline Execution ↗ for commit eb1b161.
☁️ Nx Cloud last updated this comment at |
Coly010
reviewed
Feb 5, 2025
| @@ -54,7 +54,7 @@ export function startLocalRegistry({ | |||
|
|
|||
| process.env.npm_config_registry = registry; | |||
| execSync( | |||
| `npm config set //${listenAddress}:${port}/:_authToken "secretVerdaccioToken"`, | |||
| `npm config set //${listenAddress}:${port}/:_authToken "secretVerdaccioToken" --ws=false`, | |||
There was a problem hiding this comment.
Do we always want --ws=false?
There was a problem hiding this comment.
It has no effects if workspaces is not used. If workspaces are used it is required.
Coly010
approved these changes
Feb 5, 2025
FrozenPandaz
pushed a commit
that referenced
this pull request
Feb 6, 2025
When we run inferred Jest tasks with workspaces enabled, it'll result in an error like this: ``` npm ERR! A complete log of this run can be found in: /Users/jack/.npm/_logs/2025-02-05T13_41_51_079Z-debug-0.log Error: Command failed: npm config set //localhost:4873/:_authToken "secretVerdaccioToken" npm ERR! code ENOWORKSPACES npm ERR! This command does not support workspaces. ``` This is because the cwd is the project root (e.g. `packages/mypkg-e2e`), and `npm config set` cannot be run on packages inside the workspaces. By passing `--ws=false`, it'll only be run in the workspace root and won't error. ## Current Behavior Jest e2e tests inferred from `@nx/jest/plugin` fail when starting a local registry. ## Expected Behavior Jest e2e tests should work even if they are inferred (or have cwd other than workspace root). ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes # (cherry picked from commit 0944e34)
FrozenPandaz
pushed a commit
that referenced
this pull request
Feb 6, 2025
When we run inferred Jest tasks with workspaces enabled, it'll result in an error like this: ``` npm ERR! A complete log of this run can be found in: /Users/jack/.npm/_logs/2025-02-05T13_41_51_079Z-debug-0.log Error: Command failed: npm config set //localhost:4873/:_authToken "secretVerdaccioToken" npm ERR! code ENOWORKSPACES npm ERR! This command does not support workspaces. ``` This is because the cwd is the project root (e.g. `packages/mypkg-e2e`), and `npm config set` cannot be run on packages inside the workspaces. By passing `--ws=false`, it'll only be run in the workspace root and won't error. ## Current Behavior Jest e2e tests inferred from `@nx/jest/plugin` fail when starting a local registry. ## Expected Behavior Jest e2e tests should work even if they are inferred (or have cwd other than workspace root). ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes # (cherry picked from commit 0944e34)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we run inferred Jest tasks with workspaces enabled, it'll result in an error like this:
This is because the cwd is the project root (e.g.
packages/mypkg-e2e), andnpm config setcannot be run on packages inside the workspaces. By passing--ws=false, it'll only be run in the workspace root and won't error.Current Behavior
Jest e2e tests inferred from
@nx/jest/pluginfail when starting a local registry.Expected Behavior
Jest e2e tests should work even if they are inferred (or have cwd other than workspace root).
Related Issue(s)
Fixes #