-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): add multi hash fn #29935
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
View your CI Pipeline Execution ↗ for commit d2702ae.
☁️ Nx Cloud last updated this comment at |
3b7bf05
to
9b48db9
Compare
🐳 We have a release for that!This PR has a release associated with it. You can try it out using this command: npx [email protected] my-workspace Or just copy this version and use it in your own command: 0.0.0-pr-29935-9b48db9
To request a new release for this pull request, mention someone from the Nx team or the |
69b1c71
to
eb72bfc
Compare
eb72bfc
to
b2840f8
Compare
🐳 We have a release for that!This PR has a release associated with it. You can try it out using this command: npx [email protected] my-workspace Or just copy this version and use it in your own command: 0.0.0-pr-29935-b2840f8
To request a new release for this pull request, mention someone from the Nx team or the |
b2840f8
to
eb23e4b
Compare
eb23e4b
to
7872f76
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small comments, but I wont block the approval.
7872f76
to
d2702ae
Compare
Improve the perf of the `@nx/js/typescript` plugin both in cold and warm scenarios. The main changes done are: - Batch some processing to do it once instead of doing it per config file (avoids some duplicated processing) - Use a custom TS host to read tsconfig files to reduce I/O operations - Cache tsconfig files' reads Benchmark results in a repo with 656 TS projects: ``` # Before the changes Cold (NX_CACHE_PROJECT_GRAPH=false): ~2285 ms Warm (NX_CACHE_PROJECT_GRAPH=true): ~2142 ms # After the changes Cold (NX_CACHE_PROJECT_GRAPH=false): ~597 ms Warm (NX_CACHE_PROJECT_GRAPH=true): ~220 ms ``` Note: Once #29935 is merged. I'll send another change to batch the file hashes. ## Current Behavior ## Expected Behavior ## Related Issue(s) Fixes #
Improve the perf of the `@nx/js/typescript` plugin both in cold and warm scenarios. The main changes done are: - Batch some processing to do it once instead of doing it per config file (avoids some duplicated processing) - Use a custom TS host to read tsconfig files to reduce I/O operations - Cache tsconfig files' reads Benchmark results in a repo with 656 TS projects: ``` # Before the changes Cold (NX_CACHE_PROJECT_GRAPH=false): ~2285 ms Warm (NX_CACHE_PROJECT_GRAPH=true): ~2142 ms # After the changes Cold (NX_CACHE_PROJECT_GRAPH=false): ~597 ms Warm (NX_CACHE_PROJECT_GRAPH=true): ~220 ms ``` Note: Once #29935 is merged. I'll send another change to batch the file hashes. ## Current Behavior ## Expected Behavior ## Related Issue(s) Fixes #
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
Expected Behavior
Related Issue(s)
Fixes #