Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): handle failures writing to the cache #7349

Merged
merged 1 commit into from
Oct 15, 2021
Merged

fix(core): handle failures writing to the cache #7349

merged 1 commit into from
Oct 15, 2021

Conversation

FrozenPandaz
Copy link
Collaborator

@FrozenPandaz FrozenPandaz commented Oct 13, 2021 •
edited
Loading

Current Behavior

When writing to the cache fails for some reason (multiple nx processes writing at the same time), Nx crashes.

Expected Behavior

When writing to the cache fails, Nx will retry several more times. If none of those attempts succeed, Nx crashes.

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Oct 13, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/F2XVBQRBiohJYuCcsnkutHvt4QWd
✅ Preview: Canceled

[Deployment for 73dafe3 canceled]

@nx-cloud
Copy link

nx-cloud bot commented Oct 13, 2021 •
edited
Loading

Nx Cloud Report

CI ran the following commands for commit 73dafe3. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx affected --target=build --base=39c290d6b6251cd704995f06e810edd7e8e65b70 --head=73dafe3e668d5c86bd317a38689cebe7c7de9ff4 --parallel --max-parallel=3
#000000 nx affected --target=e2e --base=39c290d6b6251cd704995f06e810edd7e8e65b70 --head=73dafe3e668d5c86bd317a38689cebe7c7de9ff4 --exclude=e2e-next,e2e-gatsby,e2e-workspace-create,e2e-workspace-integrations,e2e-workspace-core,e2e-react,e2e-web,e2e-angular-extensions,e2e-angular-core,e2e-cli,e2e-nx-plugin,e2e-storybook,e2e-cypress,e2e-node,e2e-linter,e2e-je...
#000000 nx affected --target=e2e --base=39c290d6b6251cd704995f06e810edd7e8e65b70 --head=73dafe3e668d5c86bd317a38689cebe7c7de9ff4 --exclude=e2e-react-native,e2e-detox
#000000 nx affected --target=lint --base=39c290d6b6251cd704995f06e810edd7e8e65b70 --head=73dafe3e668d5c86bd317a38689cebe7c7de9ff4 --parallel --max-parallel=4
#000000 nx affected --target=test --base=39c290d6b6251cd704995f06e810edd7e8e65b70 --head=73dafe3e668d5c86bd317a38689cebe7c7de9ff4 --parallel --max-parallel=2
#000000 nx build typedoc-theme

Sent with 💌 from NxCloud.

@FrozenPandaz FrozenPandaz force-pushed the fix-parallel-builds branch 2 times, most recently from 4b9b215 to 6455210 Compare October 13, 2021 21:40
@FrozenPandaz FrozenPandaz changed the title fix(core): handle failures writing to the cache because fix(core): handle failures writing to the cache Oct 13, 2021
@FrozenPandaz FrozenPandaz merged commit 3520d7f into nrwl:master Oct 15, 2021
@FrozenPandaz FrozenPandaz deleted the fix-parallel-builds branch October 15, 2021 14:31
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@FrozenPandaz