Skip to content

wip

Sign in for the full log view
This check has been archived and is scheduled for deletion. Learn more about checks retention
GitHub Actions / clippy succeeded Jan 8, 2024 in 0s

clippy

4 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 4
Note 0
Help 0

Versions

  • rustc 1.75.0 (82e1608df 2023-12-21)
  • cargo 1.75.0 (1d8b05cdd 2023-11-20)
  • clippy 0.1.75 (82e1608 2023-12-21)

Annotations

Check warning on line 213 in ntex/src/web/types/payload.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this block may be rewritten with the `?` operator 

warning: this block may be rewritten with the `?` operator
   --> ntex/src/web/types/payload.rs:211:9
    |
211 | /         if let Err(e) = cfg.check_mimetype(req) {
212 | |             return Err(e);
213 | |         }
    | |_________^ help: replace it with: `cfg.check_mimetype(req)?;`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark
    = note: `#[warn(clippy::question_mark)]` on by default

Check warning on line 514 in ntex-glommio/src/io.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this `RefCell` reference is held across an `await` point 

warning: this `RefCell` reference is held across an `await` point
   --> ntex-glommio/src/io.rs:514:41
    |
514 | ...                   io.0.borrow()
    |                       ^^^^^^^^^^^^^
    |
    = help: ensure the reference is dropped before calling `await`
note: these are all the `await` points this reference is held through
   --> ntex-glommio/src/io.rs:516:46
    |
516 | ...                   .await
    |                        ^^^^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#await_holding_refcell_ref

Check warning on line 206 in ntex-glommio/src/io.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this `RefCell` reference is held across an `await` point 

warning: this `RefCell` reference is held across an `await` point
   --> ntex-glommio/src/io.rs:206:41
    |
206 | ...                   io.0.borrow()
    |                       ^^^^^^^^^^^^^
    |
    = help: ensure the reference is dropped before calling `await`
note: these are all the `await` points this reference is held through
   --> ntex-glommio/src/io.rs:208:46
    |
208 | ...                   .await
    |                        ^^^^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#await_holding_refcell_ref
    = note: `#[warn(clippy::await_holding_refcell_ref)]` on by default

Check warning on line 145 in ntex-rt/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

very complex type used. Consider factoring parts into `type` definitions 

warning: very complex type used. Consider factoring parts into `type` definitions
   --> ntex-rt/src/lib.rs:145:13
    |
145 |             Either<task::JoinHandle<T>, Pin<Box<dyn Future<Output = Result<T, Canceled>>>>>,
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
    = note: `#[warn(clippy::type_complexity)]` on by default
View more details on GitHub Actions