Fix phpstan findings

nucleos · Feb 8, 2025 · 4b47bef · 4b47bef
1 parent 271c948
commit 4b47bef
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/src/Application.php b/src/Application.php
@@ -30,7 +30,7 @@ public function __construct()
         $this->add(new ChangesCommand());
     }
 
-    public function add(Command $command): ?Command
+    public function add(Command $command): Command
     {
         $command = parent::add($command);
 

diff --git a/src/Changelog/Formatter/PrefixGroupFormatter.php b/src/Changelog/Formatter/PrefixGroupFormatter.php
@@ -161,7 +161,7 @@ private function parseLines(array $lines, array $groupedLines): array
             preg_match('/^([0-9A-f]+) (?:\[(.*)\] )?(.*)/', $line, $matches, PREG_UNMATCHED_AS_NULL);
 
             $type = strtoupper($matches[2] ?? $this->defaultGroup);
-            $line = \sprintf('- [%s] %s', $matches[1], $matches[3]);
+            $line = \sprintf('- [%s] %s', $matches[1] ?? '', $matches[3] ?? '');
 
             $groupedLines[$type][] = $line;
         }

diff --git a/src/VersionControl/Git.php b/src/VersionControl/Git.php
@@ -43,7 +43,7 @@ public function getModifiedFilesSince(string $tag): array
     {
         $files = [];
 
-        $lines  = array_filter($this->executeGitCommand(\sprintf('diff --name-status %s..HEAD', $tag)));
+        $lines  = array_filter($this->executeGitCommand(\sprintf('diff --name-status %s..HEAD', $tag)), static function (string $line) { return '' !== $line; });
 
         foreach ($lines as $line) {
             [$state, $file] = explode("\t", (string) $line);