Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MPE for AY22/23 S2 #3414

Merged
merged 3 commits into from
Oct 10, 2022
Merged

Update MPE for AY22/23 S2 #3414

merged 3 commits into from
Oct 10, 2022

Conversation

chrisgzf
Copy link
Member

Update NUSMods for the MPE which happens on 10-14 Oct.

@vercel
Copy link

vercel bot commented Oct 10, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nusmods-export ❌ Failed (Inspect) Oct 10, 2022 at 0:04AM (UTC)
nusmods-website ✅ Ready (Inspect) Visit Preview Oct 10, 2022 at 0:04AM (UTC)

@codecov
Copy link

codecov bot commented Oct 10, 2022

Codecov Report

Base: 53.26% // Head: 53.04% // Decreases project coverage by -0.22% ⚠️

Coverage data is based on head (0069318) compared to base (4d3738b).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3414      +/-   ##
==========================================
- Coverage   53.26%   53.04%   -0.23%     
==========================================
  Files         270      270              
  Lines        5756     5756              
  Branches     1333     1333              
==========================================
- Hits         3066     3053      -13     
- Misses       2690     2703      +13     
Impacted Files Coverage Δ
website/src/views/mpe/MpeContainer.tsx 0.00% <ø> (ø)
website/src/views/mpe/constants.ts 0.00% <0.00%> (ø)
website/src/featureFlags.ts 100.00% <100.00%> (ø)
...ews/components/notfications/ModRegNotification.tsx 34.61% <0.00%> (-46.16%) ⬇️
website/src/views/components/CloseButton.tsx 40.00% <0.00%> (-40.00%) ⬇️
website/src/views/layout/Navtabs.tsx 100.00% <0.00%> (+10.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@chrisgzf chrisgzf merged commit aaf8a03 into master Oct 10, 2022
@chrisgzf chrisgzf deleted the mpe-staging branch October 10, 2022 00:10
@chrisgzf chrisgzf restored the mpe-staging branch October 10, 2022 00:10
zwliew added a commit that referenced this pull request Aug 5, 2023
Vercel disables Node 14 support on 15 Aug 2023, and Node 16 support on 6
Feb 2024. Let's future-proof and not worry about this for a while by
supporting Node 18.

References for migration to @sparticuz/chromium:
* alixaxel/chrome-aws-lambda#275
* https://github.com/Sparticuz/chrome-aws-lambda
* https://github.com/Sparticuz/chromium#migration-from-chrome-aws-lambda

References for upgrading puppeteer:
* https://pptr.dev/chromium-support

References for prior Node upgrades:
* #3417
* #3414
zwliew added a commit that referenced this pull request Aug 5, 2023
Vercel disables Node 14 support on 15 Aug 2023, and Node 16 support on 6
Feb 2024. Let's future-proof and not worry about this for a while by
supporting Node 18.

References for migration to @sparticuz/chromium:
* alixaxel/chrome-aws-lambda#275
* https://github.com/Sparticuz/chrome-aws-lambda
* https://github.com/Sparticuz/chromium#migration-from-chrome-aws-lambda

References for upgrading puppeteer:
* https://pptr.dev/chromium-support

References for prior Node upgrades:
* #3417
* #3414
zwliew added a commit that referenced this pull request Aug 5, 2023
Vercel disables Node 14 support on 15 Aug 2023, and Node 16 support on 6
Feb 2024. Let's future-proof and not worry about this for a while by
supporting Node 18.

References for migration to @sparticuz/chromium:
* alixaxel/chrome-aws-lambda#275
* https://github.com/Sparticuz/chrome-aws-lambda
* https://github.com/Sparticuz/chromium#migration-from-chrome-aws-lambda

References for upgrading puppeteer:
* https://pptr.dev/chromium-support

References for prior Node upgrades:
* #3417
* #3414
zwliew added a commit that referenced this pull request Aug 5, 2023
Vercel disables Node 14 support on 15 Aug 2023, and Node 16 support on 6
Feb 2024. Let's future-proof and not worry about this for a while by
supporting Node 18.

References for migration to @sparticuz/chromium:
* alixaxel/chrome-aws-lambda#275
* https://github.com/Sparticuz/chrome-aws-lambda
* https://github.com/Sparticuz/chromium#migration-from-chrome-aws-lambda

References for upgrading puppeteer:
* https://pptr.dev/chromium-support

References for prior Node upgrades:
* #3417
* #3414
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant