Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POC of moving NRF51_unified to common sources [former nRF52840 ONLY port] #8

Closed
wants to merge 2 commits into from

Conversation

nvlsianpu
Copy link
Owner

@nvlsianpu nvlsianpu commented Apr 13, 2017

Description

This is POC of moving NRF51 unified targets to common source for all Nordic's MCU. In directory of this port (./TARGET_NRF5_SDK13 were placed two nRF5 SDK versions: 11 and 13). HAL implementations are unified (where possible)

Changes:

renamed dir. ./sdk -> ./sdk13
copied dir. NRF5/sdk -> ./sdk11
copied dir. NRF5/TARGET_NRF51822_UNIFIED -> ./TARGET_NRF51822_UNIFIED (only non end-target files)
moved dir. NRF5/TARGET_NRF51822_UNIFIED/TARGET_NRF51_DK -> ./TARGET_NRF51822_UNIFIED/TARGET_NRF51_DK
moved dir. NRF5/TARGET_NRF51822_UNIFIED/TARGET_NRF51_DONGLE -> ./TARGET_NRF51822_UNIFIED/TARGET_NRF51_DONGLE

Added backward compatibility code to API implementation of gpio, pwm, serial, port, spi
Added backward compatibility code to BLE implementation of GAP.

Modified MCU_NRF51_UNIFIED target description in order to use moved files.
Modified NRF52840_DK targets description (small adaptation for using proper sdk version).

Ideas which needs to be discussed

  1. MCU_NRF51_UNIFIED has two 3-party child target orphan:
  • DELTA_DFCM_NNN50
  • TY51822R3
    Is it acceptable to move it with nordic targets?
  1. After applying this PR renamed port directory form TARGET_NRF5_SDK13 to TARGET_NRF5X or other more generic name. The second possibility is to join/merge TARGET_NRF5_SDK13 together with TARGET_NRF5 sources.
  2. Changes from PR are possible to be applied even before Move NRF52_DK target to NRF5_SDK13 sources ARMmbed/mbed-os#4132 will be merged in ARM mbed-os (need only rebase).

Status

POC

…ces.

rename dir. ./sdk -> ./sdk13
copy dir. NRF5/sdk -> ./sdk11
copy dir. NRF5/TARGET_NRF51822_UNIFIED -> ./TARGET_NRF51822_UNIFIED (only non end-target files)
move dir. NRF5/TARGET_NRF51822_UNIFIED/TARGET_NRF51_DK -> ./TARGET_NRF51822_UNIFIED/TARGET_NRF51_DK
move dir. NRF5/TARGET_NRF51822_UNIFIED/TARGET_NRF51_DONGLE -> ./TARGET_NRF51822_UNIFIED/TARGET_NRF51_DONGLE

Add backward compatibiliti code to API implementation of gpio, pwm, serial, port, spi
Add backward compatibiliti code to BLE implementation of GAP.
Modyfied MCU_NRF51_UNIFIED to use common sources (and SDK11) from TARGET_NRF5_SDK13
Modified MCU_NRF5280 to use SDK13
@nvlsianpu
Copy link
Owner Author

nvlsianpu commented Apr 13, 2017

FYI @pan-, @anangl, @screamerbg

@nvlsianpu
Copy link
Owner Author

ARMmbed#4245 introduce combined NRF5 + NRF52840.

@nvlsianpu nvlsianpu closed this Apr 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant