Add build support for alma 9 #146
Open
+31
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simply replaces the rpm dist with the makefile dist. The makefile dist comes from configured distro in the build.sh Signed-off-by: Geoff O'Callaghan <[email protected]>
This bypasses bug in pylorax where it guesses the size of the ext4 filesystem incorrectly (too small). This will allow Centos9S builds to occur without impacting others. Signed-off-by: Geoff O'Callaghan <[email protected]>
Signed-off-by: Geoff O'Callaghan <[email protected]>
…unner Signed-off-by: Geoff O'Callaghan <[email protected]>
Signed-off-by: Geoff O'Callaghan <[email protected]>
…kdeps Signed-off-by: Geoff O'Callaghan <[email protected]>
Signed-off-by: Geoff O'Callaghan <[email protected]>
dupondje
requested changes
Feb 24, 2025
| @@ -32,7 +32,8 @@ jobs: | |||
| strategy: | |||
| matrix: | |||
| name: [el9] | |||
| runs-on: [image-builders, "${{ matrix.name }}"] | |||
| # runs-on: [image-builders, "${{ matrix.name }}"] | |||
There was a problem hiding this comment.
I would drop the commented line.
The self-hosted node has self-hosted and image-builders tag btw.
| runs-on: [image-builders, "${{ matrix.name }}"] | ||
| - name: alma9 | ||
| container-name: almalinux9 | ||
| # runs-on: [image-builders, "${{ matrix.name }}"] |
| @@ -59,7 +59,7 @@ jobs: | |||
| image: quay.io/ovirt/buildcontainer:${{ matrix.container-name }} | |||
| volumes: | |||
| - /host/modules:/host/modules | |||
| options: --privileged | |||
| options: --privileged --ulimit=nofile=262144:262144 | |||
There was a problem hiding this comment.
Can you explain in the commit msg why it's needed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #49 #88
Notes: While this closes Issue 49, because the almalinux node builds and boots OK, there are still a number of other issues when integrating into the environment - this is due to the engine forcing the addition of centos repos and this needs to be addressed via the engine.
I have validated build with my own self-hosted runner running on the almalinux9 node. I have installed the self-hosted engine on the ovirt node after some creative disabling of some centos repositories, so this also fixes 88
Changes introduced with this PR
changes to self-hosted runners
added almalinux9 node build
fixed Centos 9 Stream build so that it now also works again (bug in pylorax that is avoided with better livemedia-creator options)
Added some documentation of how to perform local builds using vscode devcontainers
Are you the owner of the code you are sending in, or do you have permission of the owner?
y