Unescaping works not as intended and is slow #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ut using expensive C API calls - db factor out the init parameters to be a path, so that we can write tests in the future
…as intended - remove jest package and add @types/jasmine - bump packages, since otherwise some things don't work
… in the rollup.config
…ort gnome 43 < anymore
Totto16
changed the title
oae
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #296
After I made #266 and tested it, it passed all manual tests and also did perform normally. But after using it locally on real data it performs poorly, taking seconds to unescape everything in my history (I have a 500 entries history 😓 )
After investigating this issues, and reading into the source code of
default_unescape_stringI found out, that they unescape''(two single quotes) to'and tested the input of''and copying that entry, it was unescaped to'which is incorrect.Also the performance problem lies into calling C functions is rather expensive, and doing it for ~500 entries takes a few seconds, even if the C function is fast, the transition costs to much in this case.
Type of change
This also adds tests 🎉
Note the new tests fail without this patch, so they can catch errors 🎉
Checklist