Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General improvements and maintenance task #342

Merged
merged 11 commits into from
Feb 20, 2025

Conversation

Totto16
Copy link
Collaborator

@Totto16 Totto16 commented Feb 20, 2025

Description

This is a combination of #313 and some maintenance of dependencies etc

Commit List from #313

  • 039c053 ✅ used 1:1
  • 1b3ac29 ❌ using "type": "module" should be avoided, and using ts-node is fine, we don't need tsx
  • dd97dbf ❌ only works for modules, which we don't want to use
  • 8287c33 ✅ used as basis, modified a few things
  • 0c22d9a ✅ used as basis, modified some more things
  • 414a1b6 ✅ used as basis, modified a few things

Checklist

  • My code follows the style guidelines of this project
  • My commits follow the commit standards of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have checked my code and corrected any misspellings

@Totto16 Totto16 changed the title General improvments and maitainace task General improvements and maintenance task Feb 20, 2025
@Totto16
Copy link
Collaborator Author

Totto16 commented Feb 20, 2025

@QuentiumYT I used 4 of your 6 commits from #313. It modified some things. Some changes were bigger, some smaller.

Is it okay for you, if I use these modified commits, as they have your name attributed as author, even if you didn't write them entirely. I find it better to attribute you as author instead of making correction commits myself.

- some selected dependencies are bumped between major versions, these are checked to work
- others are left as is, as it is not safe to update to a new major version
- also adjust the .po files
@Totto16 Totto16 requested a review from oae February 20, 2025 16:39
@Totto16 Totto16 force-pushed the general_improvments branch from 61047aa to 8a99348 Compare February 20, 2025 18:12
@Totto16
Copy link
Collaborator Author

Totto16 commented Feb 20, 2025

@oae could you change the required action to pass to the new name Yarn CI with Node 22.x and remove the old Yarn CI with Node 20.x one. This is unfortunately necessary, as matrix actions always change name, when you update the arguments 😓

Thanks in advance ❤️

@QuentiumYT
Copy link
Contributor

Hello @Totto16 ,

Thanks for using these commits. I know this was a huge PR and there are plenty of things to discuss on. Great to see some of my changes anyway :)
You can keep my commits even if you changed a few things. Thanks for keeping some of them.

Your changes seem good to me if you want an external extra review haha. Very nice

@Totto16 Totto16 mentioned this pull request Feb 20, 2025
8 tasks
…p 2, but we use rollup 4

 install rollup-plugin-styler, that is nearly the same, but is maintained and supports rollup 4
@oae
Copy link
Owner

oae commented Feb 20, 2025

@QuentiumYT I used 4 of your 6 commits from #313. It modified some things. Some changes were bigger, some smaller.

Is it okay for you, if I use these modified commits, as they have your name attributed as author, even if you didn't write them entirely. I find it better to attribute you as author instead of making correction commits myself.

@Totto16 done

@Totto16 Totto16 merged commit 381f4a2 into oae:master Feb 20, 2025
1 check passed
@Totto16 Totto16 deleted the general_improvments branch February 20, 2025 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants