-
-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General improvements and maintenance task #342
Conversation
@QuentiumYT I used 4 of your 6 commits from #313. It modified some things. Some changes were bigger, some smaller. Is it okay for you, if I use these modified commits, as they have your name attributed as author, even if you didn't write them entirely. I find it better to attribute you as author instead of making correction commits myself. |
…sn't get picked up by rollup
- some selected dependencies are bumped between major versions, these are checked to work - others are left as is, as it is not safe to update to a new major version
- also adjust the .po files
61047aa
to
8a99348
Compare
@oae could you change the required action to pass to the new name Thanks in advance ❤️ |
Hello @Totto16 , Thanks for using these commits. I know this was a huge PR and there are plenty of things to discuss on. Great to see some of my changes anyway :) Your changes seem good to me if you want an external extra review haha. Very nice |
…p 2, but we use rollup 4 install rollup-plugin-styler, that is nearly the same, but is maintained and supports rollup 4
@Totto16 done |
Description
This is a combination of #313 and some maintenance of dependencies etc
Commit List from #313
"type": "module"
should be avoided, and using ts-node is fine, we don't need tsxChecklist