Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/runtime/registry: Remove runtime host handler factory #6073

Merged
merged 4 commits into from
Feb 21, 2025

Conversation

peternose
Copy link
Contributor

@peternose peternose commented Feb 20, 2025

Refactored committee node:

  • Removed RuntimeHostHandlerFactory as it is more cleaner to pass parameters to the constructor instead of passing a factory.
  • Removed handler and notifier from the committee node, so that we can easier stop/start the notifier.
  • Removed host provisioner (which is now generalized to provision any runtime) from the runtime registry, as it doesn't belong there.
    • It is now globally avaliable to common worker which provisions runtimes and to the key manager worker which provisions key manager runtime (maybe we need to move up also handler and notifier).

Related to:

Copy link

netlify bot commented Feb 20, 2025

Deploy Preview for oasisprotocol-oasis-core canceled.

Name Link
🔨 Latest commit bf142b9
🔍 Latest deploy log https://app.netlify.com/sites/oasisprotocol-oasis-core/deploys/67b8647b56beec00080a8f9a

@peternose peternose force-pushed the peternose/trivial/remove-handler-factory branch from 2282bcd to bf142b9 Compare February 21, 2025 11:33
@peternose peternose enabled auto-merge February 21, 2025 11:52
@peternose peternose merged commit a5ceacf into master Feb 21, 2025
5 checks passed
@peternose peternose deleted the peternose/trivial/remove-handler-factory branch February 21, 2025 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants