Fix extension WebUSB permission issue #1079
Conversation
🦙 MegaLinter status: ✅ SUCCESS
See errors details in artifact MegaLinter reports on CI Job page MegaLinter is graciously provided by |
Codecov Report
@@ Coverage Diff @@
## master #1079 +/- ##
==========================================
+ Coverage 84.88% 85.05% +0.17%
==========================================
Files 121 126 +5
Lines 2249 2309 +60
Branches 539 559 +20
==========================================
+ Hits 1909 1964 +55
- Misses 340 345 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
buberdds
force-pushed
the
buberdds/extLedgerAccess
branch
7 times, most recently
from
b3369fc to
0430931
Compare
| </Box> | ||
| )} | ||
| {connection === 'connected' && ( | ||
| <ConnectionStatusIcon label={t('ledger.extension.succeed', 'Device connected')} /> |
There was a problem hiding this comment.
Extra popup should probably automatically close after this
There was a problem hiding this comment.
Not sure if you changed this in an odd way: popup1 closes after returning to it, after success
There was a problem hiding this comment.
checked both dev and prod builds and I cannot repro this
| {webExtensionLedgerAccess ? ( | ||
| <Button | ||
| style={{ width: 'fit-content' }} | ||
| onClick={webExtensionLedgerAccess} | ||
| label={t('ledger.extension.grantAccess', 'Grant access to your Ledger')} | ||
| primary | ||
| /> |
There was a problem hiding this comment.
This flow should only be needed the first time for each unpaired ledger device, not every time. Background page already has the needed permissions.
There was a problem hiding this comment.
The only problem is that permission can be revoked at any time, right after it was granted, and we have no knowledge about it.
There was a problem hiding this comment.
How about on click: attempt to get a device and if it fails openLedgerAccessPopup
There was a problem hiding this comment.
Can you share more details? Do you want to dispatch saga action first and handle "LedgerNoDeviceSelected" differently or there is some way to get a device and checked if it's paired?
There was a problem hiding this comment.
I think just try { await TransportWebUSB.create(); to="ledger" } catch (e) { openLedgerAccessPopup() }
There was a problem hiding this comment.
If we want to create usb transport here we will have to close it in React component as well to avoid USB Transport error: Failed to execute 'claimInterface' on 'USBDevice': Unable to claim interface. At this point everything looks fine, but when I will revoke usb access and go through process again it will end up with USB Transport error: Failed to execute 'open' on 'USBDevice': The device was disconnected..
There was a problem hiding this comment.
Alright I am able to reproduce this
try {
await (await TransportWebUSB.create()).close()
navigate('/open-wallet/ledger')
} catch (e) {
webExtensionLedgerAccess()
}what's very odd is that it works after reloading background page, as if close() doesn't fully reset device communication
- start with extension having USB permission
- enumerate accounts works, cancel
- remove USB permission
- connect ledger flow, enumerate accounts does not work, cancel
- reload background page
- enumerate accounts works, cancel
- remove USB permission
- reload background page
- connect ledger flow, enumerate accounts works, cancel
buberdds
force-pushed
the
buberdds/extLedgerAccess
branch
3 times, most recently
from
9dbc6fa to
e79968f
Compare
buberdds
force-pushed
the
buberdds/extLedgerAccess
branch
2 times, most recently
from
cb8e38e to
5b56312
Compare
buberdds
force-pushed
the
buberdds/extLedgerAccess
branch
2 times, most recently
from
4e3c61f to
68eb66e
Compare
buberdds
force-pushed
the
buberdds/extLedgerAccess
branch
from
68eb66e to
117dbe3
Compare
buberdds
force-pushed
the
buberdds/extLedgerAccess
branch
from
117dbe3 to
e07f288
Compare
Fixes #1045
During sync meeting we decided to go with a popup like in a current ext.
error:
