Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make deploy.enableServiceLinks configurable #284

Merged
merged 3 commits into from
Feb 12, 2025

Conversation

jkroepke
Copy link
Contributor

@jkroepke jkroepke commented Feb 12, 2025

enableServiceLinks is a optimization setting to reduce the amount of unnecessary environment variables of a pod.

tuunit
tuunit previously requested changes Feb 12, 2025
add artifacthub change note
@jkroepke jkroepke requested a review from tuunit February 12, 2025 09:08
Copy link
Contributor

@pierluigilenoci pierluigilenoci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your contribution.
I have left some comments.

@pierluigilenoci pierluigilenoci merged commit 8d3f28c into oauth2-proxy:main Feb 12, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants