Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bridge BFO role to CHEBI role. #528

Merged
merged 3 commits into from
Mar 8, 2022
Merged

Bridge BFO role to CHEBI role. #528

merged 3 commits into from
Mar 8, 2022

Conversation

balhoff
Copy link
Member

@balhoff balhoff commented Nov 23, 2021

Addresses issue #467. This is also taken care of by the range declaration for has role, however we are still not applying range reasoning in very many places due to most people still using ELK 0.4.3.

@matentzn
Copy link
Contributor

Is RO the right place for this kind of alignment? I would imagine that once we move to ODK, much of this kind of axiomatisation should move to COB, right? In any case, I think its the right move, but this is probably one for @cmungall to judge.

@matentzn
Copy link
Contributor

Also: since our CI pipelines use Elk 0.4.3, this wont really solve our "role part of material entity" problem, right?

@balhoff
Copy link
Member Author

balhoff commented Nov 29, 2021

Also: since our CI pipelines use Elk 0.4.3, this wont really solve our "role part of material entity" problem, right?

This is meant to solve that, at least in part. has role has a range axiom that would make this less needed if the reasoner supported ranges.

@cmungall
Copy link
Contributor

@balhoff will change this to be consistent with COB (chebi:role subClassOf characteristic)

@cmungall will make it easier to obtain the COB bridging file which will be th ultimate source of truth for this

@balhoff
Copy link
Member Author

balhoff commented Feb 10, 2022

Changed to be subclass of PATO:quality, which is what I think is meant by "characteristic" above.

@balhoff balhoff requested a review from cmungall February 14, 2022 16:29
@cmungall
Copy link
Contributor

cmungall commented Mar 8, 2022

@cmungall cmungall merged commit 4b676e1 into master Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants