New example: d3/canvas to png #1514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Philippe Rivière <[email protected]>
Co-authored-by: Philippe Rivière <[email protected]>
Co-authored-by: Philippe Rivière <[email protected]>
Co-authored-by: Philippe Rivière <[email protected]>
Co-authored-by: Philippe Rivière <[email protected]>
Co-authored-by: Philippe Rivière <[email protected]>
Co-authored-by: Philippe Rivière <[email protected]>
Co-authored-by: Philippe Rivière <[email protected]>
Co-authored-by: Philippe Rivière <[email protected]>
Co-authored-by: Philippe Rivière <[email protected]>
Co-authored-by: Philippe Rivière <[email protected]>
mbostock
requested changes
Jul 11, 2024
mbostock
requested changes
Jul 11, 2024
examples/README.md
Outdated
| @@ -54,6 +54,7 @@ | |||
|
|
|||
| - [`loader-airtable`](https://observablehq.observablehq.cloud/framework-example-loader-airtable/) - Loading data from Airtable | |||
| - [`loader-arrow`](https://observablehq.observablehq.cloud/framework-example-loader-arrow/) - Generating Apache Arrow IPC files | |||
| - [`loader-canvas-to-png`](https://observablehq.observablehq.cloud/framework-example-loader-canvas-to-png/) - Generating a map server-side as a PNG file with node, canvas and D3 | |||
There was a problem hiding this comment.
This description can be shortened and better match the other descriptions. Some alternatives:
- Generating PNG from JavaScript
- Generating PNG from Node.js
- Generating PNG using node-canvas
- Generating PNG
I think my preference is (3) because most of our other data loader examples assume Node.js + JavaScript in the description, so it feels anomalous to call this one out, and it’s nice to reference the supporting library (node-canvas) explicitly.
(Also, it’s “Node.js” not “node”. Maybe “Node” is okay in some contexts, but I wouldn’t use “node” unless you are using node to refer specifically to the command you run from the terminal.)
mbostock
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
local copy of #1510 by @palewire
the example is deployed at https://observablehq.observablehq.cloud/framework-example-loader-canvas-to-png/