Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bigquery loader example #1581

Merged
merged 12 commits into from
Aug 16, 2024
Merged

bigquery loader example #1581

merged 12 commits into from
Aug 16, 2024

Conversation

Fil
Copy link
Contributor

@Fil Fil commented Aug 15, 2024

dirkbosman and others added 6 commits July 29, 2024 23:59
- trim down the project to one page
- simplify the data loader
- simplify the chart
- add information on Google service accounts
- remove screenshot
@Fil Fil requested a review from mbostock August 15, 2024 17:53
@Fil Fil enabled auto-merge (squash) August 15, 2024 17:54
Copy link
Member

@mbostock mbostock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The deploy is missing the parent config (and thus the header shared across all examples). Can you fix and then re-deploy? You have to point the deploy at the parent config using --config and then it imports the child config based on the current working directory. We should have instructions somewhere…

@Fil
Copy link
Contributor Author

Fil commented Aug 16, 2024

We should have instructions somewhere…

it's just this

yarn deploy --config ../observablehq.config.js --build

but I keep forgetting to do it on the first deploy :(

Copy link
Member

@mbostock mbostock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@Fil Fil merged commit b1d0719 into main Aug 16, 2024
4 checks passed
@Fil Fil deleted the dirkbosman/loader_google_bigquery branch August 16, 2024 20:45
@dirkbosman
Copy link
Contributor

Amazing, thanks again @mbostock & @Fil - I hope this opens up a whole lot of new insights in/through Framework & BigQuery private & public datasets <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants