Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit documentation to cite Observable Cloud support for embedding (wrong branch) #1830

Closed
wants to merge 51 commits into from

Conversation

tophtucker
Copy link
Contributor

@tophtucker tophtucker commented Nov 19, 2024

[removed]

tophtucker and others added 30 commits October 4, 2024 02:36
… primary branch in our db to current branch; add some periods to some messages where it seems appropriate for consistency
…or throwing, check local repo against configured remote repo, just repo and branch, not yet refs
tophtucker and others added 21 commits November 1, 2024 20:55
…lling back other forcing things to see if i still need them
…ck up to status quo ante; fix polling for auth to respect deployOptions.deployPollInterval, though one could argue its now too narrowly named
…stuff isnt isolated so running the tests changed my email and name. happy to have you as a collaborator, Observable User. removed --global flag... duh...
…ult branch after repo is already made, which of course does nothing for the current repo
* documentation

* reformat and type

* simpler

* clarify the logic in validateGitHubLink
fixes an uncaught Error ('Setting source repository for continuous deployment failed' was never reached)
@tophtucker tophtucker closed this Nov 19, 2024
@tophtucker tophtucker changed the title Edit documentation to cite Observable Cloud support for embedding Edit documentation to cite Observable Cloud support for embedding (wrong branch) Nov 19, 2024
@tophtucker
Copy link
Contributor Author

Sorry I branched off the wrong thing there! Fixed in #1831.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants