-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit documentation to cite Observable Cloud support for embedding (wrong branch) #1830
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… continuousDeployment for the first time
… primary branch in our db to current branch; add some periods to some messages where it seems appropriate for consistency
Co-authored-by: Mike Bostock <[email protected]>
…or throwing, check local repo against configured remote repo, just repo and branch, not yet refs
…ild of preconfigured project
…ix prettttier thing i missed
…lling back other forcing things to see if i still need them
…ck up to status quo ante; fix polling for auth to respect deployOptions.deployPollInterval, though one could argue its now too narrowly named
…stuff isnt isolated so running the tests changed my email and name. happy to have you as a collaborator, Observable User. removed --global flag... duh...
…init FIRST, duh duh duh
…ult branch after repo is already made, which of course does nothing for the current repo
* documentation * reformat and type * simpler * clarify the logic in validateGitHubLink fixes an uncaught Error ('Setting source repository for continuous deployment failed' was never reached)
Sorry I branched off the wrong thing there! Fixed in #1831. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[removed]