Skip to content

Commit

Permalink
Fix typo in (cache-check-probablity)
Browse files Browse the repository at this point in the history
I was trying to use it as documented here, but there is a typo when used
as a config file entry (the cmdline entry seems fine):
https://dune.readthedocs.io/en/stable/caching.html#reproducibility-check

We also bump the required version to 2.7, as the feature wasn't usable
before this release.

Signed-off-by: Edwin Török <[email protected]>
  • Loading branch information
edwintorok authored and rgrinberg committed Jul 28, 2020
1 parent 180ba0b commit 6a2a899
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
3 changes: 3 additions & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,9 @@ next
individual executables when they're part of an `executables` stanza group
(#3644, @rgrinberg)

- Fix typo in `cache-check-probablity` field in dune config files. This field
now requires 2.7 as it wasn't usable before this version. (#3652, @edwintorok)

2.6.1 (02/07/2020)
------------------

Expand Down
4 changes: 2 additions & 2 deletions src/dune/config.ml
Original file line number Diff line number Diff line change
Expand Up @@ -263,8 +263,8 @@ let decode =
(Dune_lang.Syntax.since Stanza.syntax (2, 0) >>> Caching.Transport.decode)
~default:default.cache_transport
and+ cache_check_probability =
field "cache-check-probablity"
(Dune_lang.Syntax.since Stanza.syntax (2, 0) >>> Dune_lang.Decoder.float)
field "cache-check-probability"
(Dune_lang.Syntax.since Stanza.syntax (2, 7) >>> Dune_lang.Decoder.float)
~default:default.cache_check_probability
and+ cache_duplication =
field "cache-duplication"
Expand Down

0 comments on commit 6a2a899

Please sign in to comment.