Add a test case for promoting a directory #3504
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Clément Pit-Claudel <[email protected]>
cpitclaudel
force-pushed
the
cpitclaudel_promote-directories
branch
from
be9de5a to
cfdb76a
Compare
|
Well, we don't support them officially yet. We added just enough in the past to get some users going, but the full support is not there yet. You can always rely on what the implementation currently does, but we don't provide any guarantee at the moment. |
|
I know this is not officially supported, but directories don't seem to be promoted correctly anymore; I get: |
|
@snowleopard do we have plans for this? |
Yes, I'm currently working on directory promotion and I already have a testsuite for it, using the right new syntax for directory targets. So I think we should close this PR in favour of the upcoming one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just realized that dune supports directory targets, but it seems that it doesn't support promoting them, so here's the feature request :) The use case is described in #3503