Fix variable CC content + add test #3695
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
History
ocaml_cflags
were removed from the:standard
set of flags to prevent flags duplication as these are always prepended to the C compiler arguments. However this is not a backward compatible change: an example of that is that it changes the content of variable%{cc}
.%{cc}
content (changed by #3565 ) #3686 to restore compatibility but it was not exactly the same either: the new CC content would not be overwritten by cflags from an env stanza which do not include:standard
.This PR
:standard
(which will provoke duplication again).cflags
defined in Env stanzas.Future work
An RFC to propose a streamlining and maybe redefine the role of the CC variable.