doc: fix jobs field in config #7381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ali Caglayan <[email protected]>
nojb
reviewed
Mar 22, 2023
There was a problem hiding this comment.
I would suggest changing the variable concurrency to jobs in
dune/src/dune_config_file/dune_config_file.ml
Line 296 in 7cd8b42
(and to propagate that renaming everywhere else)
christinerose
approved these changes
Mar 22, 2023
|
@nojb I think that can be an independent change, if we want to do it, though I am not sure it is a good idea. |
This can be backported to 3.7.x like any other change, let's discuss if there are other candidates. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #6392 we introduce the config options into the main doc. There was a typo where the
jobsstanza was written asconcurrency. Here we fix that.@emillon could you get this fix into the stable version of the docs?
I only noticed this after some users were confused about it.