Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add odoc support-files-targets #232

Merged
merged 2 commits into from
Nov 20, 2018
Merged

Add odoc support-files-targets #232

merged 2 commits into from
Nov 20, 2018

Conversation

aantron
Copy link
Contributor

@aantron aantron commented Oct 31, 2018

With this PR:

$ odoc support-files-targets
odoc.css
highlight.pack.js

The command has no options.

I assume this output is suitable for consumption. cc @dbuenzli, @rgrinberg (though I will/can make a PR to Dune to use this).

Resolves #174.

See also #153 (comment).

@dbuenzli
Copy link
Contributor

dbuenzli commented Oct 31, 2018

The command has no options.

I think this needs an -o DIR option. This is not about listing the support files it's about which file paths the odoc support-files will write.

@aantron
Copy link
Contributor Author

aantron commented Oct 31, 2018

Ok, it now has the same options as support-files:

$ odoc support-files-targets --output-dir foo
foo/odoc.css
foo/highlight.pack.js
$ odoc support-files-targets --output-dir foo --without-theme
foo/highlight.pack.js

The only problem is that the code fails if the output directory doesn't exist. I'll undo that next, but I want to check whether the output and command line are otherwise reasonable.

@dbuenzli
Copy link
Contributor

dbuenzli commented Nov 1, 2018

Thanks ! Looks to me exactly what is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants