Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] styled-ppx (0.56.0) #25663

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

davesnx
Copy link
Contributor

@davesnx davesnx commented Apr 11, 2024

Type-safe styled components for ReScript and Melange

CHANGES:

0.56.0

@samoht
Copy link
Member

samoht commented Apr 16, 2024

Something is going wrong with packages/ppx/test/snapshot/rescript/rescript-bs-config-missing-jsx-version.t/run.t. Is this expected? Should we disallow the tests for this package?

@davesnx
Copy link
Contributor Author

davesnx commented Apr 16, 2024

Let me disable the rescript tests since it requires rescript to exist, will fix it and re-push

CHANGES:

## 0.56.0

- Improvement for locations in both code-gen and error reporting (davesnx/styled-ppx#456) by @davesnx
- Support css min and max functions (davesnx/styled-ppx#411) by @lubegasimon
- Update docs (davesnx/styled-ppx#457) by @zakybilfagih
- Native support for styled.{{tag}} (davesnx/styled-ppx#461) by @zakybilfagih
- background-clip: text support by @davesnx
- Fix linear-gradient and radial-gradient (davesnx/styled-ppx#464) by @davesnx
- Rename emotion-hash into murmur2 and remove public testing cli by @davesnx
- Use server-reason-react from opam by @davesnx
@davesnx davesnx force-pushed the release-styled-ppx-0.56.0 branch from ff4880d to 185ce8b Compare April 17, 2024 12:25
@davesnx
Copy link
Contributor Author

davesnx commented Apr 18, 2024

I disabled those tests, and I'm getting a few errors that I'm not able to understand.

extras,riscv64-ocaml-5.1,styled-ppx.0.56.0,tests -> Looks like a problem with conf-npm?

extras,s390x-ocaml-5.1,styled-ppx.0.56.0

# File "packages/reason-css-parser/lib/.reason_css_parser.objs/native/_unknown_", line 1, characters 0-0:
# (cd _build/default && /home/opam/.opam/5.1/bin/ocamlopt.opt -w -40 -g -I packages/reason-css-parser/lib/.reason_css_parser.objs/byte -I packages/reason-css-parser/lib/.reason_css_parser.objs/native -I /home/opam/.opam/5.1/lib/ocaml/compiler-libs -I /home/opam/.opam/5.1/lib/ppx_deriving/runtime -I /home/opam/.opam/5.1/lib/sedlex -I packages/parser/lib/.styled_ppx_css_parser.objs/byte -I packages/parser/lib/.styled_ppx_css_parser.objs/native -intf-suffix .ml -no-alias-deps -open Reason_css_parser__ -o packages/reason-css-parser/lib/.reason_css_parser.objs/native/reason_css_parser__Parser.cmx -c -impl packages/reason-css-parser/lib/Parser.re.pp.ml)
# >> Fatal error: camlReason_css_parser__Parser.entry: function too complex, cannot complete register allocation

freebsd,freebsd-ocaml-5.1-amd64,styled-ppx.0.56.0,tests

#    $ ./compare.sh ""
# -  Hashes match: 0
# +  /tmp/dune_cram_8a4f44_.hash.t/1.sh: ./compare.sh: not found

Looks like ./compare.sh can't be found

@mseri
Copy link
Member

mseri commented Apr 25, 2024

I don;t know how to resolve the errors, I think we can merge and if some specific user encounters them they can help us fix them

@mseri mseri merged commit 2be1877 into ocaml:master Apr 26, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants