Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2 validate improvements and fixes #124

Merged
merged 4 commits into from
Jan 7, 2025

Conversation

rmouritzen-splunk
Copy link
Contributor

@rmouritzen-splunk rmouritzen-splunk commented Jan 4, 2025

Changes:

  • By default, warnings are no longer created for missing recommended attributes. This can be enabled with a new missing_recommended=true query parameter to the /api/v2/validate and /api/v2/validate_bundle APIs.
  • Mismatches on regular expression constraints on attribute types are now warnings instead of errors. (This is easier to deal with now that missing recommended attributes no longer create a flood of warnings -- at least by default.)
  • Fix bug validating attributes enabled by profile.
  • Fix validation error message for deprecated attributes.

Unrelated changes:

  • Change deprecated use of <%# for comments in Elixir HTML templates to <%--.
  • Update dependencies.

@rmouritzen-splunk rmouritzen-splunk self-assigned this Jan 4, 2025
@rmouritzen-splunk rmouritzen-splunk added bug Something isn't working enhancement New feature or request labels Jan 4, 2025
@rmouritzen-splunk rmouritzen-splunk merged commit 31c4dec into ocsf:main Jan 7, 2025
1 check passed
@rmouritzen-splunk rmouritzen-splunk deleted the fix-v2-validate branch January 7, 2025 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant