feat: asset-lake python sdk updates #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efredin
approved these changes
Mar 27, 2024
adelbertc
reviewed
Mar 27, 2024
| @@ -0,0 +1,8 @@ | |||
| update-asset-lake-schema: | |||
| cp ../cheese-pizza/python/asset-lake/asset-lake-api-openapi-3.1.0.json fern/apis/asset-lake/openapi/openapi.json | |||
There was a problem hiding this comment.
Out of curiosity what's the difference between this file and this file asset-lake-api-openapi.json in the same directory?
There was a problem hiding this comment.
Different version of the openapi spec. Version 3.0.3 is the default since it was what it started out generating I think the cli or finetuning needed something from openapi 3.1 hence extra json file. Perhaps once everything is using fern we can get rid of this.
| @@ -1,4 +1,4 @@ | |||
| { | |||
| "organization": "octoai", | |||
| "version": "0.19.9" | |||
| "version": "0.19.19" | |||
There was a problem hiding this comment.
My attempt at updating the generator and also making the fern cli client stop telling me it can be updated. I don't think it is necessary.
|
@robo-corg If Fern folks say This Is The Way I think we can go ahead - thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generated python sdk PR: https://github.com/octoml/octoai-python-sdk-fern/pull/6