Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

l10n_ch*: added QR-IBAN on bank account for Switzerland accounting #55571

Closed
wants to merge 2 commits into from
Closed

l10n_ch*: added QR-IBAN on bank account for Switzerland accounting #55571

wants to merge 2 commits into from

Conversation

rgo-odoo
Copy link
Contributor

@rgo-odoo rgo-odoo commented Aug 6, 2020

Task: 2307262

@C3POdoo C3POdoo added the RD research & development, internal work label Aug 6, 2020
@robodoo robodoo added ☑ ci/template CI 🤖 Robodoo has seen passing statuses and removed ☐ ci/template CI 🤖 Robodoo has seen passing statuses labels Aug 6, 2020
yvaucher
yvaucher suggested changes Aug 27, 2020
View reviewed changes
Copy link
Contributor

@yvaucher yvaucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QR-IBAN from invoice.invoice_partner_bank_id.l10n_ch_qr_iban must also be displayed on the report here:

https://github.com/odoo/odoo/blob/13.0/addons/l10n_ch/report/swissqr_report.xml#L103

@fclementic2c
Copy link
Contributor

QR-IBAN from invoice.invoice_partner_bank_id.l10n_ch_qr_iban must also be displayed on the report here:

Yes the report is not valid at the moment (just tested it with a customer)

@yvaucher
Copy link
Contributor

ping @jco-odoo

@jco-odoo
Copy link
Contributor

@yvaucher I am on it today. (if you have any suggestions...)

@robodoo robodoo added ☐ legal/cla CI 🤖 Robodoo has seen passing statuses and removed ☑ legal/cla labels Sep 2, 2020
@fclementic2c
Copy link
Contributor

fclementic2c commented Sep 7, 2020 •
edited
Loading

@jco-odoo @oco-odoo Any chance that we can merge this ? it is a problem on our side. Thanks

@jco-odoo
Copy link
Contributor

jco-odoo commented Sep 7, 2020

@fclementic2c To me, this is ok to merge. I just give a bit of time for the functional check.

@jco-odoo
Copy link
Contributor

jco-odoo commented Sep 8, 2020

@robodoo r+ rebase-ff

@robodoo robodoo added the r+ 👌 label Sep 8, 2020
@robodoo
Copy link
Contributor

robodoo commented Sep 8, 2020

Merge method set to rebase and fast-forward

@robodoo robodoo closed this in 40bc277 Sep 8, 2020
@robodoo robodoo temporarily deployed to merge September 8, 2020 10:16 Inactive
@fw-bot fw-bot mentioned this pull request Sep 8, 2020
Closed
@fw-bot
Copy link
Contributor

fw-bot commented Sep 12, 2020

This pull request has forward-port PRs awaiting action (not merged or closed): #57238

2 similar comments
@fw-bot
Copy link
Contributor

fw-bot commented Sep 13, 2020

This pull request has forward-port PRs awaiting action (not merged or closed): #57238

@fw-bot
Copy link
Contributor

fw-bot commented Sep 14, 2020

This pull request has forward-port PRs awaiting action (not merged or closed): #57238

@fw-bot fw-bot mentioned this pull request Sep 14, 2020
Closed
@fw-bot
Copy link
Contributor

fw-bot commented Sep 15, 2020

This pull request has forward-port PRs awaiting action (not merged or closed): #57629

This was referenced Sep 15, 2020
Closed
Closed
@yvaucher yvaucher mentioned this pull request Sep 16, 2020
Closed
@fw-bot fw-bot deleted the 13.0-l10n_ch_qr-rgo branch September 22, 2020 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jco-odoo jco-odoo jco-odoo left review comments

@yvaucher yvaucher yvaucher requested changes

@oco-odoo oco-odoo oco-odoo requested changes

Assignees
No one assigned
Labels
CI 🤖 Robodoo has seen passing statuses RD research & development, internal work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@rgo-odoo @fclementic2c @yvaucher @jco-odoo @robodoo @fw-bot @oco-odoo @C3POdoo