-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cut selection flags for write and read cuts functions #781
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #781 +/- ##
==========================================
- Coverage 93.40% 93.35% -0.05%
==========================================
Files 27 27
Lines 3486 3490 +4
==========================================
+ Hits 3256 3258 +2
- Misses 230 232 +2 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Oscar Dowson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy if you're happy. You should have permission to merge.
We're missing a test, but I'm not too worried about that.
I can create the tests. Any recommendation? |
Related with #778, this PR adds: