Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cut selection flags for write and read cuts functions #781

Merged
merged 6 commits into from
Sep 8, 2024

Conversation

Thuener
Copy link
Collaborator

@Thuener Thuener commented Sep 5, 2024

Related with #778, this PR adds:

  • cut_selection flag to use or not the cut selection algorithm when reading the files: This will significantly reduce the time to load a file
  • write_only_selected_cuts to write only the selected cuts: This will reduce the file size and reading time significantly

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 93.35%. Comparing base (d2495d6) to head (0e25ac5).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/plugins/bellman_functions.jl 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #781      +/-   ##
==========================================
- Coverage   93.40%   93.35%   -0.05%     
==========================================
  Files          27       27              
  Lines        3486     3490       +4     
==========================================
+ Hits         3256     3258       +2     
- Misses        230      232       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@odow odow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy if you're happy. You should have permission to merge.

We're missing a test, but I'm not too worried about that.

@odow odow merged commit d514d38 into odow:master Sep 8, 2024
5 of 7 checks passed
@Thuener
Copy link
Collaborator Author

Thuener commented Sep 9, 2024

I can create the tests. Any recommendation?
Just write and read and calculate the bound is enough?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants