Fix shared transition issue during from popular list to detail screen

oguzsout · Oct 10, 2024 · 8bdc017 · 8bdc017
1 parent 08478ff
commit 8bdc017
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/app/src/main/java/com/oguzdogdu/walliescompose/features/home/HomeScreen.kt b/app/src/main/java/com/oguzdogdu/walliescompose/features/home/HomeScreen.kt
@@ -459,7 +459,7 @@ private fun SharedTransitionScope.HomeListImage(
     onImageClick: (String) -> Unit,
     animatedVisibilityScope: AnimatedVisibilityScope,
 ) {
-    val sharedContentState = rememberSharedContentState(key = "mainImage-${id}")
+    val sharedContentState = rememberSharedContentState(key = "$SharedTransitionKey$id")
 
     with(animatedVisibilityScope) {
         SubcomposeAsyncImage(
@@ -478,4 +478,6 @@ private fun SharedTransitionScope.HomeListImage(
             loading = { ImageLoadingState() },
         )
     }
-}
+}
+
+const val SharedTransitionKey = "mainImage-"
diff --git a/app/src/main/java/com/oguzdogdu/walliescompose/features/popular/PopularScreen.kt b/app/src/main/java/com/oguzdogdu/walliescompose/features/popular/PopularScreen.kt
@@ -66,6 +66,7 @@ import coil.compose.SubcomposeAsyncImage
 import com.oguzdogdu.walliescompose.R
 import com.oguzdogdu.walliescompose.data.common.ImageLoadingState
 import com.oguzdogdu.walliescompose.domain.model.popular.PopularImage
+import com.oguzdogdu.walliescompose.features.home.SharedTransitionKey
 import com.oguzdogdu.walliescompose.features.popular.components.PopularEditDetails
 import com.oguzdogdu.walliescompose.ui.theme.medium
 import kotlinx.coroutines.launch
@@ -269,7 +270,7 @@ fun SharedTransitionScope.PopularListItem(
         SubcomposeAsyncImage(
             modifier = modifier
                 .sharedElement(
-                    state = rememberSharedContentState(key = "popularImage-${popularImage.id}"),
+                    state = rememberSharedContentState(key = "$SharedTransitionKey${popularImage.id}"),
                     animatedVisibilityScope = animatedVisibilityScope,
                     clipInOverlayDuringTransition = OverlayClip(RoundedCornerShape(16.dp)),
                     boundsTransform = boundsTransform