Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly depend on serde_derive #222

Closed
wants to merge 1 commit into from
Closed

Explicitly depend on serde_derive #222

wants to merge 1 commit into from

Conversation

Veykril
Copy link

@Veykril Veykril commented Mar 30, 2023

This allows serde and serde_derive to build in parallel, improving compile times (once the same change happens in camino which this crate depends on), see rust-lang/rust-analyzer#14450

@taiki-e
Copy link
Contributor

taiki-e commented Mar 30, 2023

FYI: serde recommends using the derive feature rather than depending directly on serde_derive for several reasons: serde-rs/serde#1441, serde-rs/serde#1950 (comment)

@Veykril
Copy link
Author

Veykril commented Mar 30, 2023

That is a shame but understandable 😕

@Veykril Veykril closed this Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Veykril @taiki-e