Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CodeQL workflow #4278

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Add CodeQL workflow #4278

wants to merge 1 commit into from

Conversation

sbesson
Copy link
Member

@sbesson sbesson commented Feb 25, 2025

Follow-up of #4277

The default CodeQL configuration has a few limitations including the inability to run the workflow on Pull Requests. This commit adds the configuration for executing CodeQL workflows on every push and pull request against the development branch as well as a scheduled build

@sbesson sbesson added this to the 8.1.1 milestone Feb 25, 2025
- name: Perform CodeQL Analysis
uses: github/codeql-action/analyze@v3
with:
category: "/language:${{matrix.language}}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think https://github.com/ome/bioformats/pull/4278/checks?check_run_id=37790317684 indicates that the analyze action is being run on the matrix of automatically detected languages, not the matrix defined in lines 44-47.

Copy link
Member Author

@sbesson sbesson Feb 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the actions language manually and https://github.com/ome/bioformats/pull/4278/checks?check_run_id=37796169026 looks much better

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems kind of weird that's necessary, but the output does look fine now. Probably not a bad idea to run checks against python and actions anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants