Override getAvailableOptions() in CV7000 and SVS readers
#4279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbesson
approved these changes
Feb 26, 2025
There was a problem hiding this comment.
Thanks, this probably reflects the fact the getAvailableOptions API is not really consumed anywhere at the moment.
We can discuss how to improve this so that we have some mechanism to test the API is updated accordingly. In the interim, this change is fixing the return value of an existing API so I don't think this needs to wait for a minor release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed while adding an option in #4270.
This shouldn't impact builds, but just unifies option reporting across readers. I think this was just an oversight in #4085 and #4144.
Haven't assigned a milestone yet, as not sure whether this is best done in a minor release, or OK for a patch.