InCell: only record per-timepoint channel counts if timelapse enabled #4283
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes ome#4271. In some cases, a complex timelapse with varying channel counts per timepoint will be defined but not actually used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4271. See data in
curated/incell/public/zenodo-14769820/, particularlyDataset_Fail.In some cases, a complex timelapse with varying channel counts per timepoint will be defined but not actually used. Examining the
TimeScheduleunderPlateMapinDataset3_RedoAcq_1.xdcewill show that the timepoints defined do not match up with the .tif files (where only 1 timepoint is present), but theTimeSchedulehasenabledset tofalseand so should be ignored.Without this change,
showinf -omexml Dataset3_RedoAcq_1.xdceshould throw an exception. With this change, the same test should initialize without exception, and display OME-XML and the first well's images. The ZCT dimensions and plate metadata should match up with the .tif file names.