Inomurko/start vault #676
Merged
Inomurko/start vault #676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| -days 120 \ | ||
| -nodes \ | ||
| -x509 \ | ||
| -subj "/C=US/ST=Maryland/L=Vault/O=My Company CA" \ |
There was a problem hiding this comment.
Use the same names as above
There was a problem hiding this comment.
not sure I understand?
There was a problem hiding this comment.
also, this is really not important for plasma-contracts specifically, vault just needs to standup and generate an authority account on demand. in an actual deployment this would be helm/kubernetess driven.
There was a problem hiding this comment.
True true. Just to ensure :)
souradeep-das
approved these changes
Aug 5, 2020
boolafish
reviewed
Aug 6, 2020
| vault status | ||
|
|
||
| function configure_plugin { | ||
| plugin_file="immutability-eth-plugin" |
There was a problem hiding this comment.
I know this is merged, but the space here seems off.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
splitting the PR https://github.com/omgnetwork/plasma-contracts/pull/649/files