Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update config to fluent style and update environment overrides #55

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update config to fluent style and update environment overrides #55

wants to merge 2 commits into from

Conversation

mckenzieclark
Copy link
Contributor

No description provided.

johndwells
johndwells reviewed Jan 20, 2025
View reviewed changes
Copy link
Contributor

@johndwells johndwells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mckenzieclark I think we should still include a number of key ENV variables that we leverage (and change per environment), such as:

ALLOW_UPDATES=
ALLOW_ADMIN_CHANGES=
BACKUP_ON_UPDATE=
CP_TRIGGER=
IS_SYSTEM_LIVE=

Obviously `CRAFT_` prefix those that can be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johndwells johndwells johndwells left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mckenzieclark @johndwells