Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WebSearch Retriever Microservice #209

Merged
merged 22 commits into from
Jun 24, 2024
Merged

Conversation

Spycsh
Copy link
Member

@Spycsh Spycsh commented Jun 18, 2024

Description

Add Web Retriever Microservice

Issues

opea-project/GenAIExamples#306

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)

Dependencies

chromadb
google-api-python-client>=2.100.0
bs4
html2text

Tests

tests/test_web_retrievers_langchain.sh

@Spycsh
Copy link
Member Author

Spycsh commented Jun 18, 2024

CI environment should have

export GOOGLE_API_KEY=xxx
export GOOGLE_CSE_ID=xxx

before test is triggered.

This PR should not be merged until SearchQnA Example PR is ready.

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 16 lines in your changes missing coverage. Please review.

Files Coverage Δ
comps/cores/mega/constants.py 98.11% <100.00%> (ø)
comps/cores/mega/gateway.py 26.48% <15.78%> (ø)

@chensuyue
Copy link
Collaborator

Codecov Report

Attention: Patch coverage is 20.00000% with 16 lines in your changes missing coverage. Please review.

Files Coverage Δ
comps/cores/mega/constants.py 98.03% <100.00%> (ø)
comps/cores/mega/gateway.py 26.43% <15.78%> (ø)

@Spycsh need to enhance ut coverage, patch coverage should large than 70% for this release.

@chensuyue chensuyue mentioned this pull request Jun 20, 2024
3 tasks
@Spycsh Spycsh linked an issue Jun 20, 2024 that may be closed by this pull request
@Spycsh Spycsh merged commit 6557688 into opea-project:main Jun 24, 2024
9 checks passed
xwu99 pushed a commit to xwu99/GenAIComps that referenced this pull request Jun 24, 2024
* add gateway

Signed-off-by: Spycsh <[email protected]>

* Add web retriever comp

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* add entry

* add persistent dir

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* add correct delete

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix test

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update test_web_retrievers_langchain.sh

* Update test_web_retrievers_langchain.sh

* revert

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Spycsh <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: chen, suyue <[email protected]>
Signed-off-by: Wu, Xiaochang <[email protected]>
xwu99 pushed a commit to xwu99/GenAIComps that referenced this pull request Jun 24, 2024
* add gateway

Signed-off-by: Spycsh <[email protected]>

* Add web retriever comp

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* add entry

* add persistent dir

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* add correct delete

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix test

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update test_web_retrievers_langchain.sh

* Update test_web_retrievers_langchain.sh

* revert

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Spycsh <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: chen, suyue <[email protected]>
Signed-off-by: Wu, Xiaochang <[email protected]>
sharanshirodkar7 pushed a commit to sharanshirodkar7/GenAIComps that referenced this pull request Jul 9, 2024
* add gateway

Signed-off-by: Spycsh <[email protected]>

* Add web retriever comp

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* add entry

* add persistent dir

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* add correct delete

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix test

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update test_web_retrievers_langchain.sh

* Update test_web_retrievers_langchain.sh

* revert

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Spycsh <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: chen, suyue <[email protected]>
Signed-off-by: sharanshirodkar7 <[email protected]>
yogeshmpandey pushed a commit to yogeshmpandey/GenAIComps that referenced this pull request Jul 10, 2024
* add gateway

Signed-off-by: Spycsh <[email protected]>

* Add web retriever comp

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* add entry

* add persistent dir

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* add correct delete

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix test

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update test_web_retrievers_langchain.sh

* Update test_web_retrievers_langchain.sh

* revert

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Spycsh <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: chen, suyue <[email protected]>
Signed-off-by: Yogesh Pandey <[email protected]>
dwhitena pushed a commit to predictionguard/GenAIComps that referenced this pull request Jul 24, 2024
* add gateway

Signed-off-by: Spycsh <[email protected]>

* Add web retriever comp

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* add entry

* add persistent dir

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* add correct delete

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix test

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update test_web_retrievers_langchain.sh

* Update test_web_retrievers_langchain.sh

* revert

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Spycsh <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: chen, suyue <[email protected]>
Signed-off-by: Daniel Whitenack <[email protected]>
lkk12014402 pushed a commit that referenced this pull request Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SearchQnA
4 participants