Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prompt_registry: Unifying API endpoint port #443

Merged
merged 2 commits into from
Aug 12, 2024

Conversation

hteeyeoh
Copy link
Collaborator

@hteeyeoh hteeyeoh commented Aug 9, 2024

Description

Update prompt registry microservices with unify port to adapt with recent microservices wrapper function update.
Unifying all port for API endpoints for prompt registry services with recent register_microservice wrapper function update.

Issues

List the issue or RFC link this PR is working on. If there is no such link, please mark it as n/a.
N/A

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • [* ] Others (enhancement, documentation, validation, etc.)

Dependencies

N/A

Tests

Describe the tests that you ran to verify your changes.
Already exist in main branch. Updating it with this changes.

@hteeyeoh hteeyeoh force-pushed the update_prompt_reg branch from 4461f03 to c5fc316 Compare August 9, 2024 06:57
Unifying all port for API endpoints for prompt registry services with
recent register_microservice wrapper function update.

Signed-off-by: Yeoh, Hoong Tee <[email protected]>
@hteeyeoh hteeyeoh force-pushed the update_prompt_reg branch from ea34cb1 to 73e093d Compare August 9, 2024 09:55
@lkk12014402
Copy link
Collaborator

LGTM

@ftian1 ftian1 merged commit 27a01ee into opea-project:main Aug 12, 2024
7 checks passed
xiguiw pushed a commit to xiguiw/GenAIComps that referenced this pull request Aug 12, 2024
* prompt_registry: Unifying API endpoint port

Unifying all port for API endpoints for prompt registry services with
recent register_microservice wrapper function update.

Signed-off-by: Yeoh, Hoong Tee <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Yeoh, Hoong Tee <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
BaoHuiling pushed a commit to siddhivelankar23/GenAIComps that referenced this pull request Aug 15, 2024
* prompt_registry: Unifying API endpoint port

Unifying all port for API endpoints for prompt registry services with
recent register_microservice wrapper function update.

Signed-off-by: Yeoh, Hoong Tee <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Yeoh, Hoong Tee <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
BaoHuiling pushed a commit to siddhivelankar23/GenAIComps that referenced this pull request Aug 15, 2024
* prompt_registry: Unifying API endpoint port

Unifying all port for API endpoints for prompt registry services with
recent register_microservice wrapper function update.

Signed-off-by: Yeoh, Hoong Tee <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Yeoh, Hoong Tee <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: BaoHuiling <[email protected]>
sharanshirodkar7 pushed a commit to predictionguard/pg-GenAIComps that referenced this pull request Sep 3, 2024
* prompt_registry: Unifying API endpoint port

Unifying all port for API endpoints for prompt registry services with
recent register_microservice wrapper function update.

Signed-off-by: Yeoh, Hoong Tee <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Yeoh, Hoong Tee <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@hteeyeoh hteeyeoh deleted the update_prompt_reg branch September 5, 2024 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants