-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Long context for DocSum #981
Conversation
Signed-off-by: Xinyao Wang <[email protected]>
Signed-off-by: Xinyao Wang <[email protected]>
Signed-off-by: Xinyao Wang <[email protected]>
Signed-off-by: Xinyao Wang <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
for more information, see https://pre-commit.ci
docsum wrapper for TGI failed in CI with: |
@eero-t How long does it usually take for these PR's to get reviewed? I opened a couple this week... |
I'm not developer in this project, but people assume PR to be incomplete / not ready for review when it fails CI tests. (If you think CI failure is not due to your own changes, file ticket for it, and state that it blocks the PR.) Once CI tests pass, I think you could ping here one of the people who've reviewed / merged other PRs, if nobody comments it within few days / weeks (depending on how urgent you think it is). As you're from Intel, you could also ping OPEA Intel devs internally. |
Signed-off-by: Xinyao Wang <[email protected]>
Hi, sorry I was busy with other projects some time ago, now I will continue to fix this PR, it should be ready in 1~2 workdays! |
I do not see why
|
Signed-off-by: Xinyao Wang <[email protected]>
Signed-off-by: Xinyao Wang <[email protected]>
Signed-off-by: Xinyao Wang <[email protected]>
Signed-off-by: Xinyao Wang <[email protected]>
for more information, see https://pre-commit.ci
Current CI failure is due to bad
Please use |
Signed-off-by: Xinyao Wang <[email protected]>
Signed-off-by: Xinyao Wang <[email protected]>
Signed-off-by: Xinyao Wang <[email protected]>
* docsum four Signed-off-by: Xinyao Wang <[email protected]> * support 4 modes for docsum Signed-off-by: Xinyao Wang <[email protected]> * fix Signed-off-by: Xinyao Wang <[email protected]> * fix bug Signed-off-by: Xinyao Wang <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * refine for docsum tgi Signed-off-by: Xinyao Wang <[email protected]> * add docsum for ut and vllm Signed-off-by: Xinyao Wang <[email protected]> * fix bug Signed-off-by: Xinyao Wang <[email protected]> * fix bug Signed-off-by: Xinyao Wang <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix ut bug Signed-off-by: Xinyao Wang <[email protected]> * fix ut bug Signed-off-by: Xinyao Wang <[email protected]> * set default value Signed-off-by: Xinyao Wang <[email protected]> --------- Signed-off-by: Xinyao Wang <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Description
Support Long context for DocSum with four modes:
• Stuff (Default mode): input actual tokens, need to increase the max_input_token if want to use large context
• Truncate: truncate the tokens exceed the limitation
• Map_reduce: split the inputs into multiple chunks, map each document to an individual summary, then consolidate those summaries into a single global summary
• Refine: split the inputs into multiple chunks, generate summary for the first one, then combine with the second, loops over every remaining chunks to get the final summary
Issues
List the issue or RFC link this PR is working on. If there is no such link, please mark it as
n/a
.Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
List the newly introduced 3rd party dependency if exists.
Tests
Describe the tests that you ran to verify your changes.