Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChatQnA - Add Terraform and Ansible Modules information #970

Merged

Conversation

lucasmelogithub
Copy link
Contributor

Description

  • Intel has developed Terraform and Ansible Modules.

  • These have now been enhanced to provision Xeon based Cloud Instances and to automate deployment of OPEA ChatQnA

Issues

Addresses: #560 #962 #963

Type of change

List the type of change like below. Please delete options that are not relevant.

  • [ x ] Documentation

Dependencies

List the newly introduced 3rd party dependency if exists.

Tests

Validated deployments following Terraform/Ansible Modules README.md

@lucasmelogithub lucasmelogithub force-pushed the lmelo-chatqna-terraform-docs branch from e5ec9d3 to 6e9fff1 Compare October 16, 2024 17:47
@kevinintel kevinintel requested a review from mkbhanda October 18, 2024 07:20
@mkbhanda
Copy link
Collaborator

Please publish your scripts in the OPEA repo. That way OPEA is self contained and the launch scripts are readily available through just a purview of the repository, beyond embedded in a readme file. Do consider naming the script OPEA single node VM or something to that effect and add some text perhaps that suggests number of vCPUs, disk size based on model or example pipeline, so its generic and can be used for more than ChatQnA, re-use being my intent. Also anticipating these scripts changing a bit as other handware vendors join the effort.

@lucasmelogithub
Copy link
Contributor Author

Please publish your scripts in the OPEA repo. That way OPEA is self contained and the launch scripts are readily available through just a purview of the repository, beyond embedded in a readme file. Do consider naming the script OPEA single node VM or something to that effect and add some text perhaps that suggests number of vCPUs, disk size based on model or example pipeline, so its generic and can be used for more than ChatQnA, re-use being my intent. Also anticipating these scripts changing a bit as other handware vendors join the effort.

Feedback received, I'm thinking through it and will propose a change.

@lucasmelogithub
Copy link
Contributor Author

Malini and I had a conversation.
I went over the existing Terraform Modules that have been used beyond OPEA and the Ansible playbooks.
The agreement is

  • For now, leave links on each Use Case in README, decide on future later.
  • We will revisit as needed, the Terraform Examples and Ansible Playbooks can be moved to OPEA if we think that is a better design long term.

In addition, we will add generic VM examples to the GenInfra repository with another PR.

Copy link
Collaborator

@mkbhanda mkbhanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@mkbhanda mkbhanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@ashahba ashahba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mkbhanda mkbhanda merged commit 7c9ed04 into opea-project:main Nov 13, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants