Update residential.py #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change in the lighting load function is necessary since in the original code the lighting was adapted when the occupants were asleep or away. The standby-use was only included one time-step before the appliance was turned on, otherwise it was zero. The removal of the indent fixes this problem.
|
I don't feel I understand enough what's going on in this part of the code. @cprotopa, do you have more experience with this file? |
|
Boy, this code is complicated! |
|
Then I propose we’ll just stick to Silke’s changes for now and I’ll keep my changes for a different pull request, as they are not really relevant here. I’ll take care of this tonight! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lighting is adapted when the occupants are asleep or away.
The standby-use is only included one time-step before the appliance is turned on.
In this file these problems are fixed.