-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.deb inside of oqsprovider-linux-x64.zip 0.5.3 does not work & prevents OpenSSL from loading #339
Comments
Downloaded 0.5.3.zip source... rebuilt .deb with seems like it's just the uploaded .debs which are corrupt |
Thanks for the report and your tests: This is definitely a bug. The binaries have been taken from the CI run(s) on the released branch, so we'll need to investigate what went wrong in that process... |
Thank you, also, just out of curiosity, are you planning on providing .debs for liboqs as well? Having pre-built debs for provider is of limited benefit when you still have to compile liboqs manually |
The But your question correctly points to other setups. Would you think a .deb |
A statically-linked .deb would be great. I run this on my home PC and 6 servers. I normally only have compiler/library/build-tool stuff installed on my home PC. I've been compiling / building .debs there and then copying to 5 of the 6 servers. But one server is ARM64 and I couldn't figure out if cross-compiling was possible so I had to install all the build stuff & libraries on that server too. |
For the short-term, would it be more straightforward to have two binaries for oqs-provider: one without liboqs (like now), one with liboqs? If the two binaries are bundled together with oqs-provider, less risk of mismatches. |
The idea would not be to bundle two binaries but to statically link liboqs into oqsprovider, thus resulting in another single, large shared lib that OpenSSL Van load. Need to try this. |
That makes sense too. |
… directory layout. (#377) This commit aims to fix #338 and #339. It fixes #338 by setting [`CPACK_DEBIAN_PACKAGE_ARCHITECTURE`] to the architecture used by CMake. To do so, we inspect the value of [`CMAKE_SYSTEM_PROCESSOR`], which tells us the target architecture. A test has been added to ensure that the target architecture of the output .deb is `arm64`. This commit also fixes #339 by creating a configuration called `DebPack` which sets the right file paths for `cpack`. When `cpack` is invoked with `-C DebPack`, `lib/ossl-modules`, `lib` and `include/oqs-provider` are being used as destination directories. [`CPACK_DEBIAN_PACKAGE_ARCHITECTURE`]: https://cmake.org/cmake/help/latest/cpack_gen/deb.html#variable:CPACK_DEBIAN_PACKAGE_ARCHITECTURE [`CMAKE_SYSTEM_PROCESSOR`]: https://cmake.org/cmake/help/latest/variable/CMAKE_SYSTEM_PROCESSOR.html#variable:CMAKE_SYSTEM_PROCESSOR Signed-off-by: thb-sb <[email protected]>
Describe the bug
Installing this .deb deleted my existing
/usr/lib/x86_64-linux-gnu/ossl-modules/oqsprovider.so
(from an older .deb) from all my servers and did not replace it, instead it dumped a bunch of files into a/__w/
directory which appears to be in error:This caused all my OpenSSL-linked services (Apache etc) to be unable to start and caused me to be unable to run curl and other programs
also causes OpenSSL commands to fail:
The text was updated successfully, but these errors were encountered: